Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-17934 site: drive from sitemap.tsv #4033

Merged
merged 10 commits into from
Sep 13, 2024
Merged

CLDR-17934 site: drive from sitemap.tsv #4033

merged 10 commits into from
Sep 13, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Sep 10, 2024 •
edited
Loading

CLDR-17934

  • This PR completes the ticket.

  • sitemap.tsv now controls the order and hierarchy

  • errors will be given from build.mjs (and at PR CI time) if a page is missing or other errs

  • this PR DOES NOT reorg the site at all, but it paves the way for reorg

  • also de-yellow the title line

image

ALLOW_MANY_COMMITS=true

@srl295 srl295 self-assigned this Sep 10, 2024
@github-actions GitHub Actions
Copy link

✨ deployed to https://2273c3fa.cldr.pages.dev

@github-actions github-actions bot added the Site Update Updates docs/site label Sep 10, 2024
@srl295 srl295 force-pushed the srl295/cldr-17934/gen-sitemap branch from 208412e to 8fb8c93 Compare September 11, 2024 21:51
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • docs/site/_layouts/page.html is different
  • docs/site/package-lock.json is no longer changed in the branch
  • docs/site/package.json is no longer changed in the branch
  • docs/site/robots.txt is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@github-actions GitHub Actions
Copy link

✨ deployed to https://e2cec51b.cldr.pages.dev

@github-actions GitHub Actions
Copy link

✨ deployed to https://e4e1e9a0.cldr.pages.dev

@github-actions GitHub Actions
Copy link

✨ deployed to https://7b73ad71.cldr.pages.dev

macchiati
macchiati reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TSV looks good

@srl295 srl295 changed the title 🚧 CLDR-17934 site: sitemap and reorg CLDR-17934 site: sitemap and reorg Sep 12, 2024
@srl295 srl295 marked this pull request as ready for review September 12, 2024 23:29
@github-actions GitHub Actions
Copy link

✨ deployed to https://4eb01037.cldr.pages.dev

@srl295 srl295 changed the title CLDR-17934 site: sitemap and reorg CLDR-17934 site: drive from sitemap.tsv Sep 12, 2024
@github-actions GitHub Actions
Copy link

✨ deployed to https://84413198.cldr.pages.dev

@github-actions GitHub Actions
Copy link

✨ deployed to https://cc302802.cldr.pages.dev

@AEApple
Copy link
Contributor

AEApple commented Sep 12, 2024

Will we just re-order the TSV in a different ticket?

@macchiati
Copy link
Member

Will we just re-order the TSV in a different ticket?

We will be able to make PRs to change the sitemap, so we should have a lot of flexibility.
For example, I think stable-links-info needs to go into internal development (shouldn't be so prominent) soon

@github-actions GitHub Actions
Copy link

✨ deployed to https://aa5166ab.cldr.pages.dev

@srl295 srl295 merged commit 45e1059 into main Sep 13, 2024
14 checks passed
@srl295 srl295 deleted the srl295/cldr-17934/gen-sitemap branch September 13, 2024 14:19
haytenf pushed a commit to haytenf/cldr that referenced this pull request Sep 17, 2024
@srl295 @haytenf
CLDR-17934 site: drive from sitemap.tsv (unicode-org#4033)
545b281
conradarcturus pushed a commit that referenced this pull request Sep 25, 2024
@srl295 @conradarcturus
CLDR-17934 site: drive from sitemap.tsv (#4033)
820f34f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macchiati macchiati macchiati approved these changes

@AEApple AEApple Awaiting requested review from AEApple

@btangmu btangmu Awaiting requested review from btangmu

Assignees

@srl295 srl295

Labels
Site Update Updates docs/site
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srl295 @AEApple @macchiati