Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17830 BRS update subdivision translations #3990

Conversation

macchiati
Copy link
Member

CLDR-17830

Adds names from wikidata. Note that some items disappear, because the codes were deprecated.

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@AEApple
Copy link
Contributor

AEApple commented Aug 28, 2024

What leads some of these items to be provisional status, while the newer items have status contributed?

@macchiati
Copy link
Member Author

macchiati commented Aug 28, 2024 via email

@btangmu
Copy link
Member

btangmu commented Aug 28, 2024

There are quite a few changes such as

mammd → mamar
inct → incg

I don't know how to evaluate those, or really any of the numerous changes in this PR. Where is there documentation about CLDR getting names from wikidata?

@macchiati
Copy link
Member Author

macchiati commented Aug 28, 2024 via email

@macchiati
Copy link
Member Author

Updated tooling to change the new values to provisional, for consistency.

@macchiati
Copy link
Member Author

Ping, would like to merge this by EOD if possible

@AEApple
Copy link
Contributor

AEApple commented Aug 28, 2024

any idea why so many island territories are being removed? Is that expected?

@btangmu
Copy link
Member

btangmu commented Aug 28, 2024

The documentation is basically to run the tool

Meaning WikiSubdivisionLanguages.java, I assume -- that wasn't obvious in the earlier version of this PR. I'll approve with a rubber stamp

@macchiati
Copy link
Member Author

Over the years, I've looked into some of the big revamps for various regions. Sometimes it is because of big revamps in governmental structures, sometimes just to make the codes match the actual governmental structures more clearly.

@macchiati macchiati merged commit 90b4fa1 into unicode-org:main Aug 28, 2024
12 checks passed
@macchiati
Copy link
Member Author

Right, WikiSubdivisionLanguages.java. Sorry for being to terse.

@macchiati macchiati deleted the CLDR-17830-BRS-update-subdivision-translations branch August 28, 2024 23:41
haytenf pushed a commit to haytenf/cldr that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants