Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17572 Move LR marker div below star #3981

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

btangmu
Copy link
Member

@btangmu btangmu commented Aug 23, 2024

-Move the LR marker div below the i-star icon, simply by moving the call to checkLRmarker a few lines lower

-Also remove a comment in the same file about appendExample which is no longer true, and remove the export for appendExample which is no longer needed

CLDR-17572

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

-Move the LR marker div below the i-star icon, simply by moving the call to checkLRmarker a few lines lower

-Also remove a comment in the same file about appendExample which is no longer true, and remove the export for appendExample which is no longer needed
@btangmu btangmu self-assigned this Aug 23, 2024
@btangmu
Copy link
Member Author

btangmu commented Aug 23, 2024

Screenshot with this change, showing the star on the line above the added LR marker div:
image

@btangmu btangmu merged commit 5ba3bf6 into unicode-org:main Aug 23, 2024
14 checks passed
@btangmu btangmu deleted the t17572_b branch August 23, 2024 18:11
haytenf pushed a commit to haytenf/cldr that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants