Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17535 Remove obsolete tools, fix UncheckedIOExceptions #3972

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

macchiati
Copy link
Member

@macchiati macchiati commented Aug 19, 2024

CLDR-17535

Did some cleanup after #3966

  • Removed obsolete tools

  • Used ICUUncheckedException (the java equiv. was causing problems with eclipse, and there's no functional difference)

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@macchiati macchiati requested a review from srl295 August 19, 2024 23:11
@macchiati macchiati marked this pull request as ready for review August 19, 2024 23:11
srl295
srl295 previously approved these changes Aug 20, 2024
@macchiati
Copy link
Member Author

Hmmm. When I ran Maven test locally, it didn't pick up on the missing symbols, even after a Maven clean. So I could only see these problems on the server after committing.

@srl295
Copy link
Member

srl295 commented Aug 20, 2024

Hmmm. When I ran Maven test locally, it didn't pick up on the missing symbols, even after a Maven clean. So I could only see these problems on the server after committing.

could try mvn install and then test.

@macchiati macchiati requested a review from srl295 August 20, 2024 16:25
@macchiati macchiati merged commit de74f74 into unicode-org:main Aug 20, 2024
12 checks passed
@macchiati macchiati deleted the CLDR-17535-cleanup branch August 20, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants