-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-17751 add ZWG, drop ZWL #3956
Conversation
Where is ZWG? |
My thought too! |
- update ZWG per ISO amendment - retain USD as valid due to feedback and articles - update English
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
yea… missing something important! |
This actually looks wrong in staging? ZWL and ZWG don't appear properly split out. Also I expect ZWL to have a date range, but only one date is showing? |
What are you seeing on staging? (if there is no "to" value, that just means that there is no set 'termination' date. That's typically for the current currency valid for a country) |
- update additional metadata - lowercase g for gold in the cases
- pull in full ISO update - exclude ZWG from coverage for v46 (will pickup next time)
- need to skip both ZWG and ZWL from coverage.
@roozbehp appreciate your re-review. Github was down when I made the other, so i forgot that it was still in progress. |
- for some reason, it was getting gummed up for en_Dsrt (no cross script inheritance)
@macchiati got a null pointer in |
I found the issue. CountItems silently completed because I passed the -Dmethod parameter incorrectly. Noted this on https://unicode-org.atlassian.net/browse/CLDR-17555 |
CLDR-17751
ALLOW_MANY_COMMITS=true