Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17751 add ZWG, drop ZWL #3956

Merged
merged 7 commits into from
Aug 15, 2024
Merged

CLDR-17751 add ZWG, drop ZWL #3956

merged 7 commits into from
Aug 15, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Aug 13, 2024

  • update ZWG per ISO amendment
  • retain USD as valid due to feedback and articles
  • update English

CLDR-17751

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@AEApple
Copy link
Contributor

AEApple commented Aug 13, 2024

Where is ZWG?

@macchiati
Copy link
Member

My thought too!

- update ZWG per ISO amendment
- retain USD as valid due to feedback and articles
- update English
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • common/main/en.xml is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

macchiati
macchiati previously approved these changes Aug 13, 2024
@srl295
Copy link
Member Author

srl295 commented Aug 13, 2024

My thought too!

yea… missing something important!

@srl295 srl295 marked this pull request as ready for review August 13, 2024 21:47
AEApple
AEApple previously approved these changes Aug 13, 2024
@AEApple AEApple self-requested a review August 13, 2024 21:55
@AEApple
Copy link
Contributor

AEApple commented Aug 13, 2024

This actually looks wrong in staging? ZWL and ZWG don't appear properly split out. Also I expect ZWL to have a date range, but only one date is showing?

@macchiati
Copy link
Member

What are you seeing on staging?

(if there is no "to" value, that just means that there is no set 'termination' date. That's typically for the current currency valid for a country)

common/main/en.xml Outdated Show resolved Hide resolved
- update additional metadata
- lowercase g for gold in the cases
@srl295 srl295 dismissed stale reviews from AEApple and macchiati via 5ed8b94 August 14, 2024 15:49
roozbehp
roozbehp previously approved these changes Aug 14, 2024
- pull in full ISO update
- exclude ZWG from coverage for v46 (will pickup next time)
roozbehp
roozbehp previously approved these changes Aug 15, 2024
- need to skip both ZWG and ZWL from coverage.
@srl295
Copy link
Member Author

srl295 commented Aug 15, 2024

@roozbehp appreciate your re-review. Github was down when I made the other, so i forgot that it was still in progress.

@srl295 srl295 marked this pull request as draft August 15, 2024 19:10
- for some reason, it was getting gummed up for en_Dsrt (no cross script inheritance)
@srl295 srl295 requested a review from macchiati August 15, 2024 19:41
@srl295
Copy link
Member Author

srl295 commented Aug 15, 2024

@macchiati got a null pointer in en_Dsrt - it was trying to compare it as a logical group

@srl295
Copy link
Member Author

srl295 commented Aug 15, 2024

I found the issue. CountItems silently completed because I passed the -Dmethod parameter incorrectly. Noted this on https://unicode-org.atlassian.net/browse/CLDR-17555

@srl295 srl295 marked this pull request as ready for review August 15, 2024 22:05
@srl295 srl295 requested a review from roozbehp August 15, 2024 22:05
@srl295 srl295 merged commit 2b08423 into main Aug 15, 2024
16 checks passed
@srl295 srl295 deleted the cldr-17751/zwg branch August 15, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants