-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-10347 show one example for each day period, excluding midnight #3949
CLDR-10347 show one example for each day period, excluding midnight #3949
Conversation
6aff062
to
cf294f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these :) It looks great. My only feedback is based on style and I'm myself also pretty new to CLDR so any feedback is optional.
Thanks for including screenshots. A recommendation I have for those screenshots to make it more readable is to 1) zoom in on the specific areas that the difference is (the context is good for like 1 screenshot but then the others are just harder to quickly grok). and 2) use markdown tables like this (see the markdown documentation):
Context | Before | After |
---|---|---|
I'm showing X | Insert the before image | Insert the after image |
I'm now showing Y | Insert the before image | Insert the after image |
Regardless none of these comments are blocking so I'm happy to accept if you think its ready -- but I'll leave it open ended in case one of the more seasoned contributors wants to take a look.
tools/cldr-code/src/main/java/org/unicode/cldr/test/ExampleGenerator.java
Show resolved
Hide resolved
tools/cldr-code/src/main/java/org/unicode/cldr/test/ExampleGenerator.java
Outdated
Show resolved
Hide resolved
tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestExampleGenerator.java
Outdated
Show resolved
Hide resolved
tools/cldr-code/src/main/java/org/unicode/cldr/test/ExampleGenerator.java
Outdated
Show resolved
Hide resolved
tools/cldr-code/src/main/java/org/unicode/cldr/test/ExampleGenerator.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
The checks weren't run while in draft, so now running |
@haytenf the Fixed formatting using spotless commit message needed to be
|
"jira-ticket — Commit message for 2d1b73d fails validation" |
2d1b73d
to
2c29a6f
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1123,6 +1123,42 @@ private void checkDayPeriod( | |||
checkPathValue(exampleGenerator, path, cldrFile.getStringValue(path), expected); | |||
} | |||
|
|||
public void TestAllDayPeriods() { // excludes midnight, see ICU-12278 | |||
checkDayPeriodsForLocale( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfetto!
CLDR-10347 Show one example for each day period. Currently suppresses examples for the day period "midnight" (due to ICU-12278, lack of controlled use of midnight), but handles remaining day periods and adds relevant samples.
*Only 2 day periods are defined in Quechua, original code produces 3 examples for every locale, so modification results in fewer examples
ALLOW_MANY_COMMITS=true