CLDR-17776 disallow reports if vetting closed #3840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back end side: - Change CheckCLDR.Phase.getShowRowAction() to allow pathValueInfo and pathHeader to be optional (null) - add convenience functions on StatusAction - Report API returns 403 forbidden if NOT in phase where voting is allowed.
- pop up error on voting or read error
|
Also, fix the popup message if an internal err comes up. (The final UI for reports is to hide the voting buttons if you can't vote.) 
|
- UI: disable radio group if canVote is false. - cldrReport: update API to expose canVote - ReportAPI: expose canVote over REST if the user can vote on the report
|
UI if voting is closed. (It still shows the voting status including your own vote) 
|
pedberg-icu
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back end side:
CLDR-17776
ALLOW_MANY_COMMITS=true