Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-17532 improve CheckWidths message for annotations #3809

Merged
merged 1 commit into from
Jun 17, 2024
Merged

CLDR-17532 improve CheckWidths message for annotations #3809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tools/cldr-code/src/main/java/org/unicode/cldr/test/CheckWidths.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,8 @@ public Limit(
this.subtype = Subtype.valueTooWide;
break;
case SET_ELEMENTS:
this.message = "Expected no more than {0} items(s), but was {1}.";
this.message =
"There cannot be more than {3} item(s), and it is recommended to not have more than {0} item(s). Found {1} item(s).";
this.subtype = Subtype.tooManyValues;
break;
default:
Expand Down Expand Up @@ -220,7 +221,12 @@ boolean hasProblem(
.setCause(cause)
.setMainType(errorType)
.setSubtype(subtype)
.setMessage(message, warningReference, valueMeasure, percent));
.setMessage(
message,
warningReference,
valueMeasure,
percent,
errorReference));
return true;
}
}
Expand Down
Loading