Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17582 Tweak the emoji collation/English #3787

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

macchiati
Copy link
Member

@macchiati macchiati commented Jun 5, 2024

CLDR-17582

  • This incorporates the change from the ESR for the collation order of certain marine animals
  • It also makes a fix to Mx Claus (from 'claus'), an oversight in a previous PR
  • And it adds back Vulcan as a keyword for 'vulcan salute', which was deemed safe.

Cf.

Updated instructions in separate PR: #3788

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@nedley
Copy link

nedley commented Jun 5, 2024

LGTM

Two suggestions for "Mx Claus": you can mark this PR as resolving CLDR-17701, and preemptively fix the capitalization in your copy of emoji-test.txt, since it will get the fix the next time it is regenerated by unicodetools.

@macchiati macchiati marked this pull request as draft June 5, 2024 23:21
@macchiati
Copy link
Member Author

PS. This is draft until I get the emoji-ordering-rules.txt file from Ned.

@macchiati
Copy link
Member Author

macchiati commented Jun 5, 2024 via email

@macchiati macchiati marked this pull request as ready for review June 5, 2024 23:54
@macchiati
Copy link
Member Author

Ping — I'd like to get this in the next push and the changes are small.

Copy link
Member

@btangmu btangmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: I'm not familiar with the new emoji like 🪏 or the principles for ordering the sea creatures

@macchiati macchiati merged commit f2715ad into unicode-org:main Jun 6, 2024
7 checks passed
@macchiati macchiati deleted the CLDR-17582-Tweak-emoji branch June 6, 2024 18:04
@macchiati
Copy link
Member Author

No problem, Tom. Those come to us from the emoji WG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants