CLDR-17680 fix spurious CheckConsistentCasing and CheckCoverage #3767
Conversation
srl295
force-pushed
the
cldr-17680/casing-skip
branch
from
6834a40
to
ec146d2
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
- CheckConsistentCasing was giving a warning for scripts that don't need casing - CheckCoverage was giving an warning when plurals were == root, rather than a warning when plurals were missing
srl295
force-pushed
the
cldr-17680/casing-skip
branch
from
ec146d2
to
3875f8b
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
| if ((types == null || types.isEmpty()) && !SpecialLocales.isScratchLocale(locale)) { | ||
| possibleErrors.add( | ||
| new CheckStatus() | ||
| .setCause(this) | ||
| .setMainType(CheckStatus.warningType) | ||
| .setSubtype(Subtype.incorrectCasing) | ||
| .setMessage("Could not load casing info for {0}", locale)); | ||
| } |
There was a problem hiding this comment.
Previously, this warning would fire for Arabic, etc. because the script is not cased, so control would reach line 70. Then types is checked again on this line and the warning fires.
The change moves the warning to line 67, so it fires only if casing is expected but not present.
| PluralInfo pluralInfo = | ||
| supplementalData.getPlurals(PluralType.cardinal, localeID, false); | ||
| if (pluralInfo == null && !SpecialLocales.isScratchLocale(localeID)) { |
There was a problem hiding this comment.
Previously, the warning would always fire for Japanese, etc, because the plural rules matched root. This changes to only fire if plural rules were not found.
It now does |
I thought issue was just where it was incorrect. It now should remove from all |
CLDR-17680
ALLOW_MANY_COMMITS=true