CLDR-15744 make sure settings.user.touch() is called #3761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs more testing |
macchiati
requested changes
May 30, 2024
good catch |
srl295
changed the title
- if the REST API is called for login instead of the older WebContext path, the lastLogin may not get updated.
srl295
force-pushed
the
cldr-17544/lastseen
branch
from
3dca2ae
to
19c2308
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
- voting and forum posts, etc, update the 'last seen' date - login/logout through different methods affect last seen - make sure the named session gets logged out, even if cookies were different
fix userlist to not be in milliseconds. Unexpected side effect of unicode-org#3692
srl295
force-pushed
the
cldr-17544/lastseen
branch
from
479d646
to
4b474fa
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
macchiati
approved these changes
May 30, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-15744
Verified:
voting and forum posts, etc, update the 'last seen' date
login/logout through different methods affect last seen
make sure the named session gets logged out, even if cookies were different
This PR completes the ticket.
ALLOW_MANY_COMMITS=true