CLDR-17669 add Organization.airbnb #3747
Conversation
- Locales.txt
- fix parent locale
|
with sr_Cyrl:
versus without sr_Cyrl:
|
fix TestCLDRLocaleCoverage to not give incorrect advice: - default content shouldn't be in Locales.txt so should be skipped. TestStandardCodes tests this. - clarified TestCLDRLocaleCoverage.TestParentCoverage to identify the two separate failure cases, of missing parentage and child-higher-than-parent
|
Test case was wrong, besides being confusing. take a look |
| + parent | ||
| + "; level=" | ||
| + parentLevel, | ||
| parentLevel != null && parentLevel.compareTo(level) >= 0); |
There was a problem hiding this comment.
two-for-one test condition
- spotless
| @@ -393,16 +393,24 @@ public void TestParentCoverage() { | |||
| if (parent == null || parent.equals(LocaleNames.ROOT)) { | |||
| break; | |||
| } | |||
| if (!defaultContentLocales.contains(parent) && !parent.equals("en_001")) { // en_001 is generated later from en_GB | |||
There was a problem hiding this comment.
The changes in formatting make it hard to see what the real change was. How did the original of this file escape being formatted by spotless?
There was a problem hiding this comment.
it didn't escape, it was formatted 'correctly'
The main change is just adding a defaultContent check. The rest is just test output changes.
- org order
| Airbnb ; sw ; modern ; T3 Swahili | ||
| Airbnb ; th ; modern ; T3 Thai | ||
| Airbnb ; fil ; modern ; T3 Filipino | ||
| Airbnb ; tr ; modern ; T2 Turkish |
There was a problem hiding this comment.
@srl295 - Can we reorder fil so it's alphabetical?
There was a problem hiding this comment.
ah, tl -> fil
yes – want a new PR for it? i'm not sure all of the others are alphabetical though. some might be by tiers
There was a problem hiding this comment.
ah, tl -> fil
yes – want a new PR for it? i'm not sure all of the others are alphabetical though. some might be by tiers
yes - sgtm! In the past it was by tier. I've been meaning to reorganize the others, but it's been low priority. I've just been adding things alphabetically for anything new.
|
Might we want to put CLDR first (by tiers), then other orgs alphabetically? I guess the main goal is to be able to find things easily. Definitely would be nice to have locales listed alphabetically. |
There's a different ticket for that. It's just not high priority. I can reassign it to you if you'd like to take it on? |
|
I think that ticket is for a tool to resort and reformat; once the tool is
in place, makes it easy to caconicalize
…On Thu, May 23, 2024, 13:06 Annemarie Apple ***@***.***> wrote:
Might we want to put CLDR first (by tiers), then other orgs
alphabetically? I guess the main goal is to be able to find things easily.
Definitely would be nice to have locales listed alphabetically.
There's a different ticket for that. It's just not high priority. I can
reassign it to you if you'd like to take it on?
—
Reply to this email directly, view it on GitHub
<#3747 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMAE5MYBDMOVJCEJG53ZDZD3RAVCNFSM6AAAAABIGEKRSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRXHEZTGMRXGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
CLDR-17669
ALLOW_MANY_COMMITS=true