-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-17111 Deprecate old style zone IDs (e.g. EST5EDT) and make them … #3736
Conversation
<type name="usdet" description="Detroit, United States" alias="America/Detroit US/Michigan"/> | ||
<type name="ushnl" description="Honolulu, United States" alias="Pacific/Honolulu US/Hawaii Pacific/Johnston"/> | ||
<type name="usind" description="Indianapolis, United States" alias="America/Indianapolis America/Fort_Wayne America/Indiana/Indianapolis US/East-Indiana" iana="America/Indiana/Indianapolis"/> | ||
<type name="usinvev" description="Vevay (Indiana), United States" alias="America/Indiana/Vevay"/> | ||
<type name="usjnu" description="Juneau (Alaska), United States" alias="America/Juneau"/> | ||
<type name="usknx" description="Knox (Indiana), United States" alias="America/Indiana/Knox America/Knox_IN US/Indiana-Starke"/> | ||
<type name="uslax" description="Los Angeles, United States" alias="America/Los_Angeles US/Pacific US/Pacific-New"/> | ||
<type name="uslax" description="Los Angeles, United States" alias="America/Los_Angeles US/Pacific US/Pacific-New PST8PDT"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<type name="uslax" description="Los Angeles, United States" alias="America/Los_Angeles US/Pacific US/Pacific-New PST8PDT"/> | |
<type name="uslax" description="Los Angeles, United States" alias="America/Los_Angeles US/Pacific US/Pacific-New PST8PDT"/> |
Typo: extra space
@@ -403,28 +403,28 @@ For terms of use, see http://www.unicode.org/copyright.html | |||
<type name="umawk" description="Wake Island, U.S. Minor Outlying Islands" alias="Pacific/Wake"/> | |||
<type name="umjon" description="Johnston Atoll, U.S. Minor Outlying Islands" deprecated="true" preferred="ushnl"/> | |||
<type name="ummdy" description="Midway Islands, U.S. Minor Outlying Islands" alias="Pacific/Midway"/> | |||
<type name="unk" description="Unknown time zone" alias="Etc/Unknown"/> | |||
<type name="unk" description="Unknown time zone" alias="Etc/Unknown Factory"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<type name="unk" description="Unknown time zone" alias="Etc/Unknown Factory"/> | |
<type name="unk" description="Unknown time zone" alias="Etc/Unknown Factory" iana="Factory"/> |
I think adding the iana
attribute here was what we agreed in the meeting today?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didn't have time to finish discussing this point but I have some concerns with using iana="Factory"
. Since ECMAScript already returns "Etc/Unknown", I think it would be a potential web compat concern if we started returning "Factory". It might be better to just change ECMA-402 to allow "Etc/Unknown" as a return value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly from the last time I investigated this, different engines handle the Etc/Unknown value returned from ICU differently. And when we discussed the prospect of adding Etc/Unknown to ECMA-402 at a TG2 meeting (I think it was June 2023), if I remember correctly Yusuke did not support adding it. Also, Anba expressed the same anti-Etc/Unknown opinion here: tc39/ecma402#825 (comment).
I'm just looking for any cross-engine consensus for what ID to return when ICU returns Etc/Unknown. I don't have a strong opinion either way. If we can convince the other implementers that Etc/Unknown is OK, then I'd support that.
This PR was just created for reviewing one of possible solutions. @justingrant and I could convince TZ database folks to make these legacy IDs as aliases. So this PR is no longer needed. #3754 created by @justingrant is reflecting coming TZ database changes (2024b). |
…aliases
CLDR-17111
ALLOW_MANY_COMMITS=true