CLDR-17298 Update syntax to permit constants not followed by a unit #3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedberg-icu
approved these changes
May 16, 2024
FrankYFTang
reviewed
Sep 24, 2024
| </ul></li> | ||
| <li><em>Note:</em> The number is an integer greater than one.</li> | ||
| <li><em>Note:</em> The <code>e</code> notation is optional: per-100-kilometer and per-1e2-kilometer are equivalent unit_identifiers.</li> |
There was a problem hiding this comment.
1e2 or 1e9 does not match “("1"[0-9]+ | [2-9][0-9])("e" ("1"[0-9]+ | [2-9][0-9]))?”
nor 1e3 1e4 1e5 etc
The part before “e” and after “e” only match “2”, “3”, “4” …. “99” with the definition of ("1"[0-9]+ | [2-9][0-9]*)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and e-notation. Also do a bit of cleanup: adding links to the important syntax elements and changing the references to prefixes to point to the unitPrefix.
CLDR-17298
ALLOW_MANY_COMMITS=true