Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17634 Verify that all prior-Basic locale names have English and Coverage #3720

Merged
merged 1 commit into from
May 15, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented May 14, 2024

Also misc improvements:

  • ToolConstants.previousVersion()
  • CalculatedCoverageLevels.forVersion() for loading prior versions
  • Level.isAbove()

CLDR-17634

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

…Coverage

Also misc improvements:
- ToolConstants.previousVersion()
- CalculatedCoverageLevels.forVersion() for loading prior versions
- Level.isAbove()
@srl295 srl295 self-assigned this May 14, 2024
@srl295 srl295 requested a review from btangmu May 14, 2024 22:36
@srl295
Copy link
Member Author

srl295 commented May 14, 2024

  • Since Coverage is locale based, I’m testing in all SupplementalDataInfo.getLanguageTcOrBasic() locales, that is if they are TC or Basic.
  • I’m testing to fail if any of those locales have any of the language XPaths at level higher than MODERN (so fail if COMPREHENSIVE)… what should the goal be here? should it fail if above MODERATE?

Example error message (fake data, with real data it passes)

org.opentest4j.AssertionFailedError: en.xml is missing translations for these languages' names:[cs, csw, cv, cy, da, de]

org.opentest4j.AssertionFailedError: coverageLevels.xml has a coverage level >modern for these language's names:[bho, brx, bs, ca, ceb, cs, cv, cy, da, doi, el, et, eu, fa]

@AEApple
Copy link
Contributor

AEApple commented May 15, 2024

Does this mean we can deprecate the BRS item?

@srl295
Copy link
Member Author

srl295 commented May 15, 2024

Does this mean we can deprecate the BRS item?

Retire that BRS debt!

Yes it should mean the test will fail during SBRS as soon as the version number is flipped. Could maybe make an option to make it fail early if you set an option?

@srl295 srl295 merged commit da3727f into unicode-org:main May 15, 2024
10 checks passed
@srl295 srl295 deleted the cldr-17634/eng-name-and-cov branch May 15, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants