CLDR-13864 Add night unit #3713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After this is merged, file a ticket to move 'special cases' into XML data. Example: There was a problem in TestCLDRPaths.TestReadPrevSDI because introducing a new quantity causes reading an old XML file fails. |
|
ping |
pedberg-icu
approved these changes
May 13, 2024
btangmu
reviewed
May 14, 2024
| @@ -1869,7 +1869,8 @@ private static final class UnitOrderHolder { | |||
| "volume-sai", | |||
| "volume-to-jp", | |||
| "volume-koku", | |||
| "mass-fun")) | |||
| "mass-fun", | |||
| "duration-night")) | |||
AEApple
reviewed
May 14, 2024
| <displayName>nights</displayName> | ||
| <unitPattern count="one">{0} night</unitPattern> | ||
| <unitPattern count="other">{0} nights</unitPattern> | ||
| <perUnitPattern>{0}/night</perUnitPattern> |
There was a problem hiding this comment.
@macchiati - Why is night different than day here? Day has '{0} per day'
|
Good catch. I'll make a PR to fix that.
…On Tue, May 14, 2024 at 2:40 PM Annemarie Apple ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In common/main/en.xml
<#3713 (comment)>:
> @@ -7021,6 +7021,12 @@ annotations.
<unitPattern count="other">{0} days</unitPattern>
<perUnitPattern>{0} per day</perUnitPattern>
</unit>
+ <unit type="duration-night">
+ <displayName>nights</displayName>
+ <unitPattern count="one">{0} night</unitPattern>
+ <unitPattern count="other">{0} nights</unitPattern>
+ <perUnitPattern>{0}/night</perUnitPattern>
@macchiati <https://github.com/macchiati> - Why is night different than
day here? Day has '{0} per day'
—
Reply to this email directly, view it on GitHub
<#3713 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEME2OKHL3OUMFGAVZP3ZCKADRAVCNFSM6AAAAABHTMLKPCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJWGUYDSMBUGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-13864
Adds unit
night, as in "Your hotel reservation is for 3 nights". Because it is metric_adjacent, will get grammarAdds to the normal places: en.xml, root.xml, units.xml, unit.xml
Because night is not convertible to either seconds or months, it has a new quantity. That is reflected in: units.xml, DtdData.java, UnitConverter.java, TestUnits.java
Also changes checkUnitLocalePreferencesTestIcu to not cause an error in testing the preferences test data file, with a CLDR-17581 LogKnownIssue.
ALLOW_MANY_COMMITS=true