CLDR-17544 In en, remove yMd in chinese calendar availableFormats #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedberg-icu
previously approved these changes
May 7, 2024
…rious and (b) can't be reproduced locally.
|
Please review |
srl295
approved these changes
May 8, 2024
Comment on lines
+309
to
311
| if (path.contains("yMd") && path.contains("chinese")) { | ||
| int debug = 0; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (path.contains("yMd") && path.contains("chinese")) { | |
| int debug = 0; | |
| } |
you should be able to do these with a conditional breakpoint, anyway
| if (rootUncovered) { | ||
| if (stringValue != null) { | ||
| // Record any cases where there are non-null, non-inherited values | ||
| if (!stringValue.equals("↑↑↑")) { |
There was a problem hiding this comment.
Suggested change
| if (!stringValue.equals("↑↑↑")) { | |
| if (!stringValue.equals(CldrUtility.INHERITANCE_MARKER)) { |
| for (Iterator<String> it = file.iterator(); it.hasNext(); ) { | ||
| String path = it.next(); | ||
| if (extraPaths.contains(path)) { | ||
| if (isExemptLocale && path.equals(exemptPathIfLocale)) { | ||
| logKnownIssue("CLDR-17544", "Can't reproduce locally"); |
There was a problem hiding this comment.
^ the message isn't clear as to what's happening.
macchiati
deleted the
CLDR-17544-In-en,-remove-yMd-in-chinese-availableFormats
branch
|
I'll make a followup PR with the tool improvements, thanks. |
srl295
reviewed
Jan 29, 2025
Comment on lines
+142
to
143
| logKnownIssue("CLDR-17544", "Can't reproduce locally"); | ||
| continue; |
There was a problem hiding this comment.
Post script: This should have been if(logKnownIssue(…)) continue; - only continue if logKnownIssue returns true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17544
This removes a value from root that isn't really needed, and fixes the example cited in the ticket.
It also adds an option to SearchCLDR to locate these kinds of issues, but doesn't address them all.
For that I'll clone the ticket.
ALLOW_MANY_COMMITS=true