CLDR-17346 ConsoleCheckCLDR fixes #3659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- could be surfaced by CLDR-17560 but more related to the code in this ticket
- allFilters had a single-checked unsynchronized lock, changed to a memoized supplier. - made it an immutable list for good measure
btangmu
approved these changes
Apr 29, 2024
|
I assume this completes the ticket |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17346
fix ConcurrentModificationException in CheckCLDR - the
allFilterswas initialized in an unsafe way. This has been latent for five monthgs in CLDR-7277also fixed another issue in the GitHub err reporting
This PR completes the ticket.
ALLOW_MANY_COMMITS=true