CLDR-15161 3rd meter: correct error count (#1671)

unicode-org · Jan 3, 2022 · a118e5e · a118e5e
1 parent 135e86f
commit a118e5e
Showing 1 changed file with 23 additions and 4 deletions.
diff --git a/tools/cldr-apps/src/main/java/org/unicode/cldr/web/api/LocaleCompletion.java b/tools/cldr-apps/src/main/java/org/unicode/cldr/web/api/LocaleCompletion.java
@@ -142,25 +142,34 @@ static LocaleCompletionResponse getLocaleCompletion(final CLDRLocale cldrLocale,
 
         final List<CheckStatus> results = new ArrayList<>();
         for (final String xpath : file) {
+            lcr.allXpaths ++;
             final Level pathLevel = covLeveller.getLevel(xpath);
             final String fullPath = file.getFullXPath(xpath);
 
             final PathHeader ph = LocaleCompletionHelper.INSTANCE.phf.fromPath(xpath);
             SurveyToolStatus surveyToolStatus = ph.getSurveyToolStatus();
             if (surveyToolStatus == SurveyToolStatus.DEPRECATED || surveyToolStatus == SurveyToolStatus.HIDE) {
+                lcr.ignoredHidden ++;
                 continue; // not visible
             }
 
-            checkCldr.check(fullPath, results, file.getStringValue(xpath));
+            checkCldr.check(xpath, results, file.getStringValue(xpath));
 
-            boolean hasError = CheckStatus.hasError(results);
+            final boolean hasError = CheckStatus.hasError(results);
+
+            final boolean statusMissing = STFactory.calculateStatus(file, baselineFile, xpath) == VoteResolver.Status.missing;
+
+            if (statusMissing) {
+                lcr.statusMissing ++;
+            }
 
             // TODO: copy and paste from CheckCLDR.getShowRowAction - CLDR-15230
             if (CheckCLDR.LIMITED_SUBMISSION && !SubmissionLocales.allowEvenIfLimited(
                     localeId,
                     xpath,
                     hasError,
-                    STFactory.calculateStatus(file, baselineFile, xpath) == VoteResolver.Status.missing)) {
+                    statusMissing)) {
+                    lcr.ignoredLimited ++;
                     continue;  // not allowed through by SubmissionLocales.
             }
 
@@ -178,7 +187,10 @@ static LocaleCompletionResponse getLocaleCompletion(final CLDRLocale cldrLocale,
                     } else {
                         lcr.addOk();
                     }
-                } // else: out of coverage level, do not count the path.
+                } else {
+                    // out of coverage level, do not count the path.
+                    lcr.ignoredOutOfCov ++;
+                }
             }
         }
         logger.info(et.toString());
@@ -193,6 +205,13 @@ public static class LocaleCompletionResponse {
         public int provisional = 0;
         final public String level;
 
+        // The following are more or less debug items
+        public int ignoredLimited = 0;
+        public int ignoredHidden = 0;
+        public int allXpaths = 0;
+        public int statusMissing = 0;
+        public int ignoredOutOfCov = 0;
+
         LocaleCompletionResponse(Level l) {
             level = l.name();
         }