Polymer 2 header migration #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
daniel-tabarcea
commented
Feb 14, 2018
•
daniel-tabarcea
commented
- connects Migrate header elements to polymer 2 etools-issues#1150
- enabled profile dropdown - country selector wip - connects unicef/etools-issues#1150
- fixed country dropdowns missing dependencies
- countries selector element now working
- reworked user data elems to mixins - more updates on the header
- fixed issues with profile saving - removed useless user binding - added data refresh dialog
- fixed app-selector issues
- fixed an issue with the profile not showing available workspaces
…unicef/etools-partnership-management into feat--polymer2-header-migration
- fixed an issue with button text not being centerd
- removed todos and deprecated code
- removed comments - removed deprecated code - added anotation - fixed spacing
adi130987
requested changes
Feb 22, 2018
| @@ -0,0 +1,182 @@ | |||
| <link rel="import" href="../../../../bower_components/polymer/polymer.html"> | |||
There was a problem hiding this comment.
wrong import, polymer-element.html is used in Polymer 2
| } | ||
| </style> | ||
|
|
||
| <template is="dom-if" if="[[countrySelectorVisible]]"> |
There was a problem hiding this comment.
dom-if.html and dom-repeat.html import missing
| <paper-dropdown-menu id="menu" label="Country" noink no-label-float> | ||
| <paper-listbox slot="dropdown-content" | ||
| id="countriesListbox" | ||
| attr-for-selected="countryId" |
There was a problem hiding this comment.
shouldn't this be country-id?
| </template> | ||
| </template> | ||
|
|
||
| <script> |
| * | ||
| * @polymer | ||
| * @customElement | ||
| * @appliedMixin CountriesDropdownMixin |
|
|
||
| _triggerCountryChangeRequest(countryId) { | ||
| this.dispatchEvent(new CustomEvent('global-loading', { | ||
| message: 'Please wait while country is changing...', |
There was a problem hiding this comment.
event bubbles and composed properties missing
There was a problem hiding this comment.
the event should be defined like this:
this.dispatchEvent(new CustomEvent('global-loading', {detail: {message: '...', active: true, loadingSource: '...'}, bubbles: true, composed: true});There was a problem hiding this comment.
all PR events should be fixed
There was a problem hiding this comment.
| @@ -0,0 +1,293 @@ | |||
| <link rel="import" href="../../../../bower_components/polymer/polymer.html"> | |||
| /** | ||
| * @polymer | ||
| * @mixinFunction | ||
| * @appliedMixin EtoolsLogsMixin |
| /** | ||
| * @polymer | ||
| * @customElement | ||
| * @appliedMixin PageHeaderMixin |
|
|
||
| static get observers() { | ||
| return [ | ||
| '_singleSectionChanged(interventionsSelected, partnersSelected, agreementsSelected)', |
There was a problem hiding this comment.
in Polymer 2 observers run even if arguments are undefined... you might need to add some validation for this
- fixed mixin anotations - fixed events
- removed duplicated methods
- fixed issue with event firing
- moved fireEvent function to commonMixin - added commonMixin imports
- created EventHelperMixin - updated imports where fireRequest is used
- fixed import
- added 'use strict' where missing
- used wrapper function for event dispatch - connects unicef/etools-issues#1020
- updated more event handlers
- fixed missing mixin apply
…ef/etools-partnership-management into feat--polymer2-header-migration
acory
approved these changes
Feb 26, 2018
| /** | ||
| * @polymer | ||
| * @customElement | ||
| * @appliesMixin PageHeaderMixin |
There was a problem hiding this comment.
update @appliesMixin PageHeaderMixin
| * @mixinFunction | ||
| */ | ||
| EtoolsPmpApp.Mixins.EventHelper = (baseClass) => class extends baseClass { | ||
|
|
There was a problem hiding this comment.
very likely that deduppingMixin might be needed here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.