Alter CSV and TSV setter methods to return self #323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for writing and maintaining this excellent library, it's been working flawlessly for us :)
I'm currently in the process of integrating the UniVocity CSV parser into one of our ETL jobs. Here's the code I came up with:
Whew, that's a lot of code. If all these various setter methods returned
this
, it would have been a lot more convenient to construct a parser instance:Ok, so that only saves one line of code (including newlines) 😅 but I would argue it's 1) easier to read, and 2) uses 2 fewer local variables. Plus it could collapse down to fewer lines and only sacrifice readability a little bit:
Anyway, that's what this PR is trying to enable. Thoughts?