Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom CsvFormatDetector #434

Closed
dmsleptsov opened this issue Dec 14, 2020 · 3 comments
Closed

Custom CsvFormatDetector #434

dmsleptsov opened this issue Dec 14, 2020 · 3 comments
Assignees
Milestone

Comments

@dmsleptsov
Copy link
Contributor

dmsleptsov commented Dec 14, 2020

Hi guys,

I need to a little bit change the logic for defining CSV separators, but I ran into the problem of the impossibility of doing this in the current implementation of the library. In my case, I need to change the logic in the CsvFormatDetector#execute method But CsvParser is a final class, moreover, the getInputAnalysisProcess method is also final. And also the CsvFormatDetector class is clearly not intended for extending, since most of the methods are private, which does not allow overriding only one method and using the parent methods. Tell me if there are any planned changes in the API or is there some other way to do it?

Thank you in advance!

jbax added a commit that referenced this issue Dec 15, 2020
@jbax
Copy link
Member

jbax commented Dec 15, 2020

Done, now you can pass your custom InputAnalysisProcess implementations to the parser settings. Also made the CsvFormatDetector public with protected methods if you want to override them.

I'll release a 2.9.1-SNAPSHOT build in an hour from now which you can use to test. Thank you for using our parsers!

@jbax jbax closed this as completed Dec 15, 2020
@jbax jbax added this to the 2.9.1 milestone Dec 15, 2020
@jbax jbax self-assigned this Dec 15, 2020
@dmsleptsov
Copy link
Contributor Author

dmsleptsov commented Dec 21, 2020

Hi @jbax

I use this repo, but the last version still 2.9.0. How soon the new build will be? Or the build is already done, am I using the wrong repository?

Thanks

@jbax
Copy link
Member

jbax commented Dec 21, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants