Adds parent property of repo endpoint #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guyzmo <[email protected]>
Signed-off-by: Guyzmo <[email protected]>
Signed-off-by: Guyzmo <[email protected]>
guyzmo
force-pushed
the
feature/api_parent_id
branch
from
89dd090
to
6d28a9c
Compare
guyzmo
changed the title
|
I just changed the content, to expose Repository* BaseRepo as 'parent' property, instead of an id. because that's more restful. |
ethantkoenig
suggested changes
May 5, 2017
gogs_client/entities.py
Outdated
| """ | ||
| Gets the repository's parent, when a fork | ||
|
|
||
| :rtype: int |
There was a problem hiding this comment.
No longer an int, right?
There was a problem hiding this comment.
yup, solved. Also made it automatically convert to GogsRepo if not None.
Signed-off-by: Guyzmo <[email protected]>
guyzmo
force-pushed
the
feature/api_parent_id
branch
from
6d28a9c
to
ddba2ac
Compare
guyzmo
referenced
this pull request
in guyzmo/git-repo
May 5, 2017
ethantkoenig
approved these changes
May 8, 2017
|
LGTM (coverage decrease is negligible) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf gogs/gogs#4484
cf gogs/go-gogs-client#64
cf go-gitea/gitea#1687
cf go-gitea/go-sdk#59