Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate legacy typeless addAssertion #581

Merged
merged 2 commits into from
Jan 21, 2019

Conversation

papandreou
Copy link
Member

Fixes #339

I think we should get this in now, as it will make addAssertion less confusing per the linked issue. Then we can remove the support in Unexpected 12 or 13.

@papandreou
Copy link
Member Author

Nice bonus info: After I changed the legacy assertions in the test suite, the check from #372 caught a handful of cases where the assertion handler mistakingly expected too many parameters. For example here: e443792?utf8=%E2%9C%93&diff=unified#diff-9d6bc70c1052e54f3f3bcbb165f036a8L258

Copy link
Member

@sunesimonsen sunesimonsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes 👍 we should have killed it in v11, but now let's do it in v12.

Copy link
Member

@alexjeffburke alexjeffburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! The fact that we have this in the core test suite is as good an indication as any that the time has come. I also found (and fixed) a couple of cases of this in plugins during the v11 work. 👍

@papandreou papandreou merged commit 0df9506 into master Jan 21, 2019
@papandreou papandreou deleted the chore/deprecateLegacyTypelessAddAssertion branch January 21, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants