Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work in node versions 8+ #18

Open
Munter opened this issue Oct 21, 2018 · 1 comment
Open

Doesn't work in node versions 8+ #18

Munter opened this issue Oct 21, 2018 · 1 comment

Comments

@Munter
Copy link
Member

Munter commented Oct 21, 2018 

/Users/munter/git/magicpen-media/node_modules/mock-fs-require-fix/lib/index.js:43
  throw new Error('Unsupported Node version: ' + nodeVersion);
  ^

Error: Unsupported Node version: 8.12.0
    at Object.<anonymous> (/Users/munter/git/magicpen-media/node_modules/mock-fs-require-fix/lib/index.js:43:9)

https://github.com/Slayer95/mock-fs/blob/master/lib/index.js#L16-L44
@papandreou
Copy link
Member

Yeah, I know. Unfortunately there's no easy fix. We're using a mock-fs fork because we need a feature that was removed in mock-fs 4:

@joelmukuthu joelmukuthu mentioned this issue Nov 13, 2018
Merged
joelmukuthu pushed a commit to unexpectedjs/unexpected-knex that referenced this issue Nov 13, 2018
chore(ci): do not run on node 8 and up
eca3ee5 
Due to unexpectedjs/unexpected-fs#18
joelmukuthu pushed a commit to unexpectedjs/unexpected-knex that referenced this issue Nov 13, 2018
Revert "chore(nvmrc): upgrade to node 8"
8fac40b 
This reverts commit 6b9e2e1 due to
unexpectedjs/unexpected-fs#18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Munter @papandreou