-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Merge unee t ins improvements - Phase 1 #892
base: master
Are you sure you want to change the base?
Conversation
Update mongo connect for Mongo 4.0 DB
Simplify env setup like bzfe
Update mongo connect for Mongo 4.0 DB
Update connection string for Mongo 4
* create new branch * Change some hardcoded to environment variable * Add config to use travis ci for dev * check deploy dev * check deploy dev * check deploy dev * check deploy dev * Deploy with full steps * change build branch Master * remove sudo and skip_cleanup in .travis.yml * remove hardcode in AWS-docker-compose.yml file * add a comment to buildspec.yml * test the meteor build step * change bcrypt from 1.0.3 (which is not supported in node12) to 3.0.6 * change deploy branch for dev to master
* Use clear variable names * Check variables * update variable in aws-env.dev * change build dev on branch master
* replace confusing variable name with a better name * update aws-env.[STAGE] for DEMO and PROD * fix linting * rename variable CLOUDINARY_URL to CLOUDINARY_API_ENDPOINT
This is related to issue #17: we need to use redeploy and use the correct value for the AWS variable `CLOUDINARY_CLOUD_NAME`
WIP - Import changes and improvements from Unee-T INS
More info:The deployment error is probably linked to a change we have to make in the on line 22, we have replaced Mongo DB version:In Unee-T INS we are using a more recent version of the Mongo DB. |
The Docker build fails https://media.dev.unee-t.com/2020-02-07/merge_unee-t_ins_improvements.txt which appears to be some fibers dependency. I think there is a crazy balancing act between:
Sidenote: Bit concerning that frontend master is also breaking: https://media.dev.unee-t.com/2020-02-07/frontend-master.txt ... I'm not sure how this happened. I can see a bcrypt error here c972242 from Dec 3rd. This should have been addressed earlier. |
I saw your latest commits to https://github.com/unee-t/frontend/blob/merge_unee-t_ins_improvements/.travis.yml to put back Docker commands instead of https://github.com/unee-t/frontend/blob/master/buildspec.yml I wish this was a separate PR titled "Deprecate CodeBuild in favour of all building happening in Travis" Then this might be sane to follow. Anyway, big issue with CodeBuild is that it doesn't integrate with Github well at all. So it is a good idea to move back to Travis imo btw. |
#750 which I think solves #892 (comment) because it locks down to .meteor/release
Trying to look into why Docker build is nor working with Node Js 12. |
#750 which I think solves #892 (comment) because it locks down to .meteor/release
Overview:
This is to make sure we can
1- Deploy the frontend (fix deployment bug identified on 06/02/2020)
2- Get some of the improvements we made in the Unee-T INS fork
3- Start working on using AWS Parameter Store variables instead of hardcoded values to make this more versatile.
Issue we MUST fix:
bcrypt fails at the install script at node-gyp rebuild
Warning:
This branch will NOT deploy with TRAVIS CI UNLESS all the settings that Travis CI needs are configured and correctly set in the Travis Setting for each environment!