This repository was archived by the owner on Feb 17, 2023. It is now read-only.
feat: migrate vite-plugin-vue2 to use vue-template-babel-compiler #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows it to use the modern ES nullish coalescing operators like syntaxes. This changeset is heavily borrowed from https://github.com/pedro-gilmora/vite-vue2 Also several packages have been updated to their recent versions to ensure this changeset works with them.
|
Nice work, I'd like to see this implemented as well. May I suggest requesting a review from one of the maintainers to hopefully get them to take a look? |
antfu
changed the title
Collaborator
|
Yes, there is no breaking. I just want to make it safer and awarable. |
Contributor
Author
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows it to use the modern ES nullish coalescing operators like syntaxes. This changeset is heavily borrowed from https://github.com/pedro-gilmora/vite-vue2