Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix trying to use AMDGPU in Base #167

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

RustyBamboo
Copy link
Contributor

Remove loading AMDGPU in AMDGPUext. This fixes the following:

julia> using AMDGPU, OMEinsum
Precompiling AMDGPUExt
        Info Given AMDGPUExt was explicitly requested, output will be shown live 
[ Info: OMEinsum loaded the AMDGPU module successfully
ERROR: LoadError: ArgumentError: Package Base does not have AMDGPU in its dependencies:
- You may have a partially installed environment. Try `Pkg.instantiate()`
  to ensure all packages in the environment are installed.
- Or, if you have Base checked out for development and have
  added AMDGPU as a dependency but haven't updated your primary
  environment's manifest file, try `Pkg.resolve()`.
- Otherwise you may need to report an issue with Base
Stacktrace:
...

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.61%. Comparing base (8c07022) to head (64c81fb).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
- Coverage   88.88%   82.61%   -6.28%     
==========================================
  Files          14       15       +1     
  Lines        1080     1162      +82     
==========================================
  Hits          960      960              
- Misses        120      202      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GiggleLiu
Copy link
Collaborator

GiggleLiu commented Apr 11, 2024

Makes sense to me. @radudiaconu0 is it safe if I merge this PR directly?

@radudiaconu0
Copy link
Contributor

Sure

@GiggleLiu GiggleLiu merged commit 327cf35 into under-Peter:master Apr 12, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants