Fix for DelegateReader swallowing exceptions #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the DelegateReader (contributed by gradle-plugin-utils library) which leads to reader exceptions being "swallowed" in some cases.
In the case of
SimpleTemplateEngineFilterReaderandYamlTransformingFilterReader, the whole input is read first before the delegate reader is created. If there is an error while reading the input, the outeruseblock tries to close the outer reader, which would then trigger the reading of the input again, leading to another "stream closed" IOException that would hide the original error. This is now fixed in gradle-plugin-utils 0.4.0.