Releases: un-ts/eslint-plugin-import-x
v4.6.1
v4.6.0
Minor Changes
-
#209
46d2360
Thanks @SukkaW! - Wheneslint-plugin-import-x
was forked fromeslint-plugin-import
, we copied over the default resolver (which iseslint-import-resolver-node
) as well. However, this resolver doesn't supportsexports
in thepackage.json
file, and the current maintainer of theeslint-import-resolver-node
(ljharb) doesn't have the time implementing this feature and he locked the issue import-js#1810.So we decided to implement our own resolver that "just works". The new resolver is built upon the
enhanced-resolve
that implements the full Node.js Resolver Algorithm. The new resolver only implements the import resolver interface v3, which means you can only use it with ESLint Flat config. For more details about the import resolver interface v3, please check out #192.In the next major version of
eslint-plugin-import-x
, we will remove theeslint-import-resolver-node
and use this new resolver by default. In the meantime, you can try out this new resolver by setting theimport-x/resolver-next
option in youreslint.config.js
file:// eslint.config.js const eslintPluginImportX = require('eslint-plugin-import-x'); const { createNodeResolver } = eslintPluginImportX; module.exports = { plugins: { 'import-x': eslintPluginImportX, }, settings: { 'import-x/resolver-next': [ // This is the new resolver we are introducing createNodeResolver({ /** * The allowed extensions the resolver will attempt to find when resolving a module * By default it uses a relaxed extension list to search for both ESM and CJS modules * You can customize this list to fit your needs * * @default ['.mjs', '.cjs', '.js', '.json', '.node'] */ extensions?: string[]; /** * Optional, the import conditions the resolver will used when reading the exports map from "package.json" * By default it uses a relaxed condition list to search for both ESM and CJS modules * You can customize this list to fit your needs * * @default ['default', 'module', 'import', 'require'] */ conditions: ['default', 'module', 'import', 'require'], // You can pass more options here, see the enhanced-resolve documentation for more details // https://github.com/webpack/enhanced-resolve/tree/v5.17.1?tab=readme-ov-file#resolver-options }), // you can add more resolvers down below require('eslint-import-resolver-typescript').createTypeScriptImportResolver( /** options of eslint-import-resolver-typescript */ ) ], }, };
We do not plan to implement reading
baseUrl
andpaths
from thetsconfig.json
file in this resolver. If you need this feature, please checkout eslint-import-resolver-typescript (also powered byenhanced-resolve
), eslint-import-resolver-oxc (powered byoxc-resolver
), eslint-import-resolver-next (also powered byoxc-resolver
), or other similar resolvers.
Patch Changes
- #206
449738f
Thanks @privatenumber! - insert type prefix without new line
v4.5.1
v4.5.0
Minor Changes
-
#192
fbf639b
Thanks @SukkaW! - The PR implements the new resolver design proposed in #40 (comment)For
eslint-plugin-import-x
usersLike the ESLint flat config allows you to use js objects (e.g. import and require) as ESLint plugins, the new
eslint-plugin-import-x
resolver settings allow you to use js objects as custom resolvers through the new settingimport-x/resolver-next
:// eslint.config.js import { createTsResolver } from '#custom-resolver'; const { createOxcResolver } = require('path/to/a/custom/resolver'); const resolverInstance = new ResolverFactory({}); const customResolverObject = { interfaceVersion: 3, name: 'my-custom-eslint-import-resolver', resolve(modPath, sourcePath) { const path = resolverInstance.resolve(modPath, sourcePath); if (path) { return { found: true, path }; } return { found: false, path: null } }; }; module.exports = { settings: { // multiple resolvers 'import-x/resolver-next': [ customResolverObject, createTsResolver(enhancedResolverOptions), createOxcResolver(oxcOptions), ], // single resolver: 'import-x/resolver-next': [createOxcResolver(oxcOptions)] } }
The new
import-x/resolver-next
no longer accepts strings as the resolver, thus will not be compatible with the ESLint legacy config (a.k.a..eslintrc
). Those who are still using the ESLint legacy config should stick withimport-x/resolver
.In the next major version of
eslint-plugin-import-x
(v5), we will rename the currently existingimport-x/resolver
toimport-x/resolver-legacy
(which allows the existing ESLint legacy config users to use their existing resolver settings), andimport-x/resolver-next
will become the newimport-x/resolver
. When ESLint v9 (the last ESLint version with ESLint legacy config support) reaches EOL in the future, we will removeimport-x/resolver-legacy
.We have also made a few breaking changes to the new resolver API design, so you can't use existing custom resolvers directly with
import-x/resolver-next
:// When migrating to `import-x/resolver-next`, you CAN'T use legacy versions of resolvers directly: module.exports = { settings: { // THIS WON'T WORK, the resolver interface required for `import-x/resolver-next` is different. 'import-x/resolver-next': [ require('eslint-import-resolver-node'), require('eslint-import-resolver-webpack'), require('some-custom-resolver') ]; } }
For easier migration, the PR also introduces a compat utility
importXResolverCompat
that you can use in youreslint.config.js
:// eslint.config.js import eslintPluginImportX, { importXResolverCompat } from 'eslint-plugin-import-x'; // or const eslintPluginImportX = require('eslint-plugin-import-x'); const { importXResolverCompat } = eslintPluginImportX; module.exports = { settings: { // THIS WILL WORK as you have wrapped the previous version of resolvers with the `importXResolverCompat` 'import-x/resolver-next': [ importXResolverCompat(require('eslint-import-resolver-node'), nodeResolveOptions), importXResolverCompat(require('eslint-import-resolver-webpack'), webpackResolveOptions), importXResolverCompat(require('some-custom-resolver'), { option1: true, option2: '' }) ]; } }
For custom import resolver developers
This is the new API design of the resolver interface:
export interface NewResolver { interfaceVersion: 3; name?: string; // This will be included in the debug log resolve: (modulePath: string, sourceFile: string) => ResolvedResult; } // The `ResultNotFound` (returned when not resolved) is the same, no changes export interface ResultNotFound { found: false; path?: undefined; } // The `ResultFound` (returned resolve result) is also the same, no changes export interface ResultFound { found: true; path: string | null; } export type ResolvedResult = ResultNotFound | ResultFound;
You will be able to import
NewResolver
fromeslint-plugin-import-x/types
.The most notable change is that
eslint-plugin-import-x
no longer passes the third argument (options
) to theresolve
function.We encourage custom resolvers' authors to consume the options outside the actual
resolve
function implementation. You can export a factory function to accept the options, this factory function will then be called inside theeslint.config.js
to get the actual resolver:// custom-resolver.js exports.createCustomResolver = (options) => { // The options are consumed outside the `resolve` function. const resolverInstance = new ResolverFactory(options); return { name: 'custom-resolver', interfaceVersion: 3, resolve(mod, source) { const found = resolverInstance.resolve(mod, {}); // Of course, you still have access to the `options` variable here inside // the `resolve` function. That's the power of JavaScript Closures~ } } }; // eslint.config.js const { createCustomResolver } = require('custom-resolver') module.exports = { settings: { 'import-x/resolver-next': [ createCustomResolver(options) ]; } }
This allows you to create a reusable resolver instance to improve the performance. With the existing version of the resolver interface, because the options are passed to the
resolver
function, you will have to create a resolver instance every time theresolve
function is called:module.exports = { interfaceVersion: 2, resolve(mod, source) { // every time the `resolve` function is called, a new instance is created // This is very slow const resolverInstance = ResolverFactory.createResolver({}); const found = resolverInstance.resolve(mod, {}); }, };
With the factory function pattern, you can create a resolver instance beforehand:
exports.createCustomResolver = (options) => { // `enhance-resolve` allows you to create a reusable instance: const resolverInstance = ResolverFactory.createResolver({}); const resolverInstance = enhanceResolve.create({}); // `oxc-resolver` also allows you to create a reusable instance: const resolverInstance = new ResolverFactory({}); return { name: "custom-resolver", interfaceVersion: 3, resolve(mod, source) { // the same re-usable instance is shared across `resolve` invocations. // more performant const found = resolverInstance.resolve(mod, {}); }, }; };
Patch Changes
-
#184
bc4de89
Thanks @marcalexiei! - fix(no-cycle): improves the type declaration of the ruleno-cycle
’smaxDepth
option -
#184
bc4de89
Thanks @marcalexiei! - fix(first): improves the type declaration of the rulefirst
's option -
#184
bc4de89
Thanks @marcalexiei! - fix(no-unused-modules): improves the type declaration of the ruleno-unused-modules
’smissingExports
option -
#184
bc4de89
Thanks @marcalexiei! - fix(no-deprecated): improve error message when no description is available
v4.4.3
v4.4.2
v4.4.0
Minor Changes
- #169
9c58269
Thanks @teidesu! - Add new rule optioncheckTypedImports
forextensions
, backports import-js#2817
Patch Changes
-
#171
9715220
Thanks @SukkaW! - Perf: avoid regexp during parser choosing -
#171
9715220
Thanks @SukkaW! - Add extra guard for ruleno-named-as-default
. A few guards are borrowed from import-js#3032, but we don't sync the rest of changes from upstream since we have already implemented a way more performant check. -
#171
9715220
Thanks @SukkaW! - More test cases forno-named-export
andno-defualt-export
rule specifically with non-modulesourceType
-
#171
9715220
Thanks @SukkaW! - Fixexport
when there is only oneTSDeclareFunction
(import-js#3065) -
#171
9715220
Thanks @SukkaW! - PreventExportMap
's cache is being tainted by incompatible parser (e.g. oldbabel-eslint
). The cache is now skipped w/ incompatible parsers, which might introduce performance impacts only for those who are using incompatible parsers. (import-js#3062) -
#171
9715220
Thanks @SukkaW! - Docs: fix a few typos here and there -
#168
5de039c
Thanks @hyoban! - Fixes #167, theno-duplicates
rule now allows co-existing inline type imports and namespace imports. -
#171
9715220
Thanks @SukkaW! - Properly fix espree parser w/ ESLint Flat Config
v4.3.1
Patch Changes
- #162
38d0081
Thanks @AaronMoat! - Fix issue whereno-duplicates
rule withprefer-inline
incorrectly marks default type and named type imports as duplicates
v4.3.0
Minor Changes
- #159
4da5388
Thanks @GoodbyeNJN! - feat: add support for using resolver object directly in settings
v4.2.1
Patch Changes
-
#148
d228129
Thanks @SukkaW! - Fixnewline-after-import
'sconsiderComments
options when lintingrequire
, backports import-js#2952 -
#147
eca73ed
Thanks @nchevsky! - Fix regression in ruleno-unused-modules
which would incorrectly initialize optionsrc
to[]
instead of[process.cwd()]
, breaking file discovery. -
#148
d228129
Thanks @SukkaW! - Fixno-duplicates
for TypeScript, backports import-js#3033