update matrix.comp and run_test#9
Conversation
|
I've tested your new version of matrix.comp. It works and produces the same matrix outputs as I had before. However I have some comments A remaining problem is the non-existing symbolic links like ounfmeta.inp which creates problems : I recommend to add the error checker on the first line : Also, this line is not considered correct in new bash version : Another correction would be to replace this section since oasis is now compiled inside each work sub-directory : and replace it by : |
|
For the my hope was that the update to the run_test would actually fix that. Perhaps this needs more testing? If you remove ounfmeta.inp from your directories (which the run_test should now do for you moving forward), do you still have this error? I added the -e in matrix.comp I think I updated the cases issue, but let me know if you don't think that's correct or it's not working. |
|
ok I didn't rerun the test so that's why I still have the ounfmeta.inp. |
This is so that when we run matrix.comp we get clean comparisons, this required making sure we remove the ounfmeta.inp input in run_test (didn't test this, just deleted it from directories) and ran the comparison for ww3_tp2.14 from this branch twice so that we can easily check if there are issues in the future (instead of seeing that 204 files change as it would be easy to skip over something important that way).
@mickaelaccensi please make sure there are not files that we should be comparing by removing all of the oasis/toy directories.