Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Service): await onPluginReady events to avoid concurrent issue #5139

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

kuitos
Copy link
Member

@kuitos kuitos commented Jul 31, 2020

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

onPluginReady event 没有 await 处理,可能导致 onPluginReady 里的变更因为时序问题而被忽略(比如在 onPluginReady 通过环境变量启用了另一个插件,另一个插件的 modifyDefaultConfig就会失效)


This change is Reviewable

@kuitos kuitos requested a review from sorrycc July 31, 2020 09:31
@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #5139 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5139   +/-   ##
=======================================
  Coverage   83.04%   83.04%           
=======================================
  Files         153      153           
  Lines        3385     3385           
  Branches      908      904    -4     
=======================================
  Hits         2811     2811           
  Misses        566      566           
  Partials        8        8           
Impacted Files Coverage Δ
packages/core/src/Service/Service.ts 96.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd3bbbc...4d73a7b. Read the comment docs.

@sorrycc sorrycc merged commit d2514a3 into master Jul 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/service-not-await branch July 31, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants