refactor: remove useless namedExports option

ref: rollup/plugins#149
umijs · Nov 3, 2020 · 797c9ba · 797c9ba
1 parent 3e41fa3
commit 797c9ba
Show file tree

Hide file tree

Showing 12 changed files with 7 additions and 27 deletions.
diff --git a/README.md b/README.md
@@ -400,10 +400,6 @@ export default {
 
 配置 rollup-plugin-commonjs 的 [include][https://github.com/rollup/rollup-plugin-commonjs#usage]。
 
-#### namedExports
-
-配置 rollup-plugin-commonjs 的 [namedExports](https://github.com/rollup/rollup-plugin-commonjs#usage)。
-
 #### nodeResolveOpts
 
 配置 [rollup-plugin-node-resolve](https://github.com/rollup/rollup-plugin-node-resolve) 参数。

diff --git a/...ages/father-build/src/fixtures/build/rollup-commonjs-deps-auto-named-exports/.fatherrc.js b/...ages/father-build/src/fixtures/build/rollup-commonjs-deps-auto-named-exports/.fatherrc.js
@@ -0,0 +1,6 @@
+
+export default {
+  umd: {
+    minFile: false,
+  },
+};
diff --git a/...-deps-named-exports/expected/index.umd.js → ...-auto-named-exports/expected/index.umd.js b/...-deps-named-exports/expected/index.umd.js → ...-auto-named-exports/expected/index.umd.js
diff --git a/...s-named-exports/node_modules/foo/index.js → ...o-named-exports/node_modules/foo/index.js b/...s-named-exports/node_modules/foo/index.js → ...o-named-exports/node_modules/foo/index.js
diff --git a/...med-exports/node_modules/foo/package.json → ...med-exports/node_modules/foo/package.json b/...med-exports/node_modules/foo/package.json → ...med-exports/node_modules/foo/package.json
diff --git a/...-commonjs-deps-named-exports/package.json → ...onjs-deps-auto-named-exports/package.json b/...-commonjs-deps-named-exports/package.json → ...onjs-deps-auto-named-exports/package.json
diff --git a/...-commonjs-deps-named-exports/src/index.js → ...onjs-deps-auto-named-exports/src/index.js b/...-commonjs-deps-named-exports/src/index.js → ...onjs-deps-auto-named-exports/src/index.js
diff --git a/packages/father-build/src/fixtures/build/rollup-commonjs-deps-named-exports/.fatherrc.js b/packages/father-build/src/fixtures/build/rollup-commonjs-deps-named-exports/.fatherrc.js
diff --git a/packages/father-build/src/getRollupConfig.ts b/packages/father-build/src/getRollupConfig.ts
@@ -49,7 +49,6 @@ export default function(opts: IGetRollupConfigOpts): RollupOptions[] {
     extraRollupPlugins = [],
     autoprefixer: autoprefixerOpts,
     include = /node_modules/,
-    namedExports,
     runtimeHelpers: runtimeHelpersOpts,
     replace: replaceOpts,
     inject: injectOpts,
@@ -257,7 +256,7 @@ export default function(opts: IGetRollupConfigOpts): RollupOptions[] {
       const extraUmdPlugins = [
         commonjs({
           include,
-          namedExports,
+          // namedExports options has been remove from https://github.com/rollup/plugins/pull/149
         }),
       ];
 

diff --git a/packages/father-build/src/schema.test.ts b/packages/father-build/src/schema.test.ts
@@ -16,7 +16,6 @@ const successValidates = {
   cssModules: [true, false, {}],
   autoprefixer: [{}],
   include: ['node_modules', /node_modules/],
-  namedExports: [{}],
   nodeResolveOpts: [{}],
   runtimeHelpers: [true, false],
   target: ['node', 'browser'],

diff --git a/packages/father-build/src/schema.ts b/packages/father-build/src/schema.ts
@@ -106,9 +106,6 @@ export default {
         { type: 'object' }
       ]
     },
-    namedExports: {
-      type: 'object',
-    },
     runtimeHelpers: {
       type: 'boolean',
     },

diff --git a/packages/father-build/src/types.d.ts b/packages/father-build/src/types.d.ts
@@ -20,10 +20,6 @@ interface IStringObject {
   [prop: string]: string;
 }
 
-interface IStringArrayObject {
-  [prop: string]: string[];
-}
-
 interface IUmd {
   globals?: IStringObject;
   name?: string;
@@ -50,7 +46,6 @@ export interface IBundleOptions {
   inject?: Object,
   autoprefixer?: Object;
   include?: string | RegExp;
-  namedExports?: IStringArrayObject;
   runtimeHelpers?: boolean;
   target?: 'node' | 'browser';
   overridesByEntry?: {