Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update Cargo.lock #187

Merged
merged 3 commits into from
Jun 20, 2023
Merged

build: update Cargo.lock #187

merged 3 commits into from
Jun 20, 2023

Conversation

mmalenic
Copy link
Member

This should've been part of #185.

Changes

  • Update Cargo.lock.

@mmalenic mmalenic enabled auto-merge June 20, 2023 02:26
@mmalenic mmalenic requested a review from brainstorm June 20, 2023 02:26
brainstorm
brainstorm requested changes Jun 20, 2023
View reviewed changes
Copy link
Member

@brainstorm brainstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of clippy failures in resolver.rs and types.rs which will most probably trip up next CI run, better fix them on this PR?

@mmalenic
Copy link
Member Author

Yes, it's the new clippy lints, e.g. clippy::let_with_type_underscore.

@brainstorm
Copy link
Member

brainstorm commented Jun 20, 2023 •
edited
Loading

Yes, it's the new clippy lints, e.g. clippy::let_with_type_underscore.

Oh, thx, keep forgetting about it: https://twitter.com/braincode/status/1653997437097484288 ... issue got fixed 2 weeks ago, btw, so it should be solved in stable soonish, I guess.

@mmalenic
Copy link
Member Author

It seems to be resolved in nightly, let me see if it is resolved in stable.

@mmalenic mmalenic requested a review from brainstorm June 20, 2023 03:33
brainstorm
brainstorm approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@brainstorm brainstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@mmalenic mmalenic added this pull request to the merge queue Jun 20, 2023
Merged via the queue into main with commit 91812ed Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brainstorm brainstorm brainstorm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmalenic @brainstorm