Conversation
sofietoft
added
review/developer
eshanrnh
approved these changes
Jul 5, 2024
Contributor
eshanrnh
left a comment
eshanrnh
left a comment
There was a problem hiding this comment.
Looks good to me, @sofietoft 🙌 I've made couple of suggestions here and there 😀
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Contributor
Author
|
Thanks for the review @eshanrnh ! I've added your suggestions. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In an attempt to streamline our documentation about registering dependencies, I've rewritten the IoC article.
We do not want to make any specific recommendations on this topic, as there are several ways of registering dependencies. Which way to choose depends on personal preference, the scenario in which you're registering the dependencies, the strategy decided on by the web agency, etc.
Instead, this article should showcase some different strategies, when they can be used, and then leave it open to people to decide which strategy fits their scenario best.
Next steps:
The idea is to find other references to this throughout the documentation, to make sure we link back to this article while also not giving the impression that there is one correct way of doing things.
Related: #5709
which is based on the discussion here umbraco/Umbraco-CMS#15432 (comment).
Type of suggestion