Skip to content

Add new Logging config#4813

Merged
sofietoft merged 5 commits intorc/11.1.0from
newConfig
Jan 11, 2023
Merged

Add new Logging config#4813
sofietoft merged 5 commits intorc/11.1.0from
newConfig

Conversation

@sofietoft
Copy link
Copy Markdown
Contributor

No description provided.

@sofietoft sofietoft marked this pull request as ready for review January 10, 2023 10:15
@sofietoft
Copy link
Copy Markdown
Contributor Author

Information in this PR is based off information here: umbraco/Umbraco-CMS#13485

Copy link
Copy Markdown
Member

@bergmania bergmania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

Copy link
Copy Markdown
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💪 I've added a couple of suggestions though.

sofietoft and others added 3 commits January 10, 2023 12:16
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@sofietoft
Copy link
Copy Markdown
Contributor Author

@eshanrnh - Restructured the last sentence. Please let me know what you think 💪

Copy link
Copy Markdown
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect 💪

@sofietoft sofietoft merged commit bc090dc into rc/11.1.0 Jan 11, 2023
@sofietoft sofietoft deleted the newConfig branch January 30, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants