Skip to content

V16 reverted updates from 17 #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nhudinh0309 merged 2 commits into from
Oct 30, 2025
Merged

V16 reverted updates from 17 #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33b45ee
Updated helpers
andr317c Oct 29, 2025
8ba4204
Bumped version
andr317c Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/helpers/ConstantHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
}

public static readonly approvedColorSettings = {
0: ['Include labels?', 'Displays colored field and a label for each color in the color picker, rather than just a colored field.'],
1: ['Colors', 'Add, remove or sort colors (and labels).'],
0: ['Include labels?', 'Stores colors as a JSON object containing both the color hex string and label, rather than just the hex string.'],
1: ['Colors', 'Add, remove or sort colors'],
}

public static readonly checkboxListSettings = {
Expand Down
4 changes: 2 additions & 2 deletions lib/helpers/UiBaseLocators.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ export class UiBaseLocators {
this.addPropertyBtn = page.getByLabel('Add property', {exact: true});
this.typeToFilterSearchTxt = page.locator('[type="search"] #input');
this.editorSettingsBtn = page.getByLabel('Editor settings');
this.labelAboveBtn = page.locator('.appearance-option').filter({hasText: 'Label above'});
this.labelAboveBtn = page.locator('button').filter({hasText: 'Label above'});
// tab: means that the tab is unnamed
this.unnamedTabTxt = page.getByTestId('tab:').getByTestId('tab:name-input').locator('#input');
this.deleteThreeDotsBtn = page.getByLabel('Delete…');
Expand Down Expand Up @@ -252,7 +252,7 @@ export class UiBaseLocators {
this.backOfficeHeader = page.locator('umb-backoffice-header');
this.failedStateButton = page.locator('uui-button[state="failed"]');
this.mediaCardItems = page.locator('uui-card-media');
this.enterPropertyEditorDescriptionTxt = this.sidebarModal.getByTestId('input:entity-description').locator('#textarea');
this.enterPropertyEditorDescriptionTxt = this.sidebarModal.getByLabel('Enter a description...');
this.breadcrumbsTemplateModal = this.sidebarModal.locator('umb-template-workspace-editor uui-breadcrumbs');
this.documentTypeNode = page.locator('uui-ref-node-document-type');
this.groupLabel = page.getByLabel('Group', {exact: true});
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@umbraco/playwright-testhelpers",
"version": "16.0.57",
"version": "16.0.58",
"description": "Test helpers for making playwright tests for Umbraco solutions",
"main": "dist/lib/index.js",
"files": [
Expand Down