V16: Updates Language menu label locator#300
Merged
nhudinh0309 merged 2 commits intov16/devfrom Oct 13, 2025
Merged
Conversation
This is to support PR umbraco/Umbraco-CMS#20458
andr317c
added a commit
that referenced
this pull request
Nov 3, 2025
* Add helper: for property action, dashboard (#294) * Add helper for property action * add dashboard helper * Update lib/helpers/UiBaseLocators.ts Co-authored-by: Nhu Dinh <150406148+nhudinh0309@users.noreply.github.com> * Bumped version --------- Co-authored-by: Lan Nguyen Thuy <lnt@umbraco.dk> Co-authored-by: Nhu Dinh <150406148+nhudinh0309@users.noreply.github.com> Co-authored-by: Nhu Dinh <hnd@umbraco.dk> * Add helper: for block custom view (#299) * add helper for block custom view * Update lib/helpers/ContentUiHelper.ts Co-authored-by: Nhu Dinh <150406148+nhudinh0309@users.noreply.github.com> * Update lib/helpers/ContentUiHelper.ts Co-authored-by: Nhu Dinh <150406148+nhudinh0309@users.noreply.github.com> * Update lib/helpers/ContentUiHelper.ts Co-authored-by: Nhu Dinh <150406148+nhudinh0309@users.noreply.github.com> * Update lib/helpers/ContentUiHelper.ts Co-authored-by: Nhu Dinh <150406148+nhudinh0309@users.noreply.github.com> * Update lib/helpers/ContentUiHelper.ts Co-authored-by: Nhu Dinh <150406148+nhudinh0309@users.noreply.github.com> * Update lib/helpers/DataTypeApiHelper.ts Co-authored-by: Nhu Dinh <150406148+nhudinh0309@users.noreply.github.com> * change locator * Fix parameter name * add verson and format code * fix conflict --------- Co-authored-by: Lan Nguyen Thuy <lnt@umbraco.dk> Co-authored-by: Nhu Dinh <150406148+nhudinh0309@users.noreply.github.com> * Add helper: for workspace view (#298) * Add helper: for workspace view * Update lib/helpers/ContentUiHelper.ts Co-authored-by: Nhu Dinh <150406148+nhudinh0309@users.noreply.github.com> * move method into UiBaseLocators * update version --------- Co-authored-by: Lan Nguyen Thuy <lnt@umbraco.dk> Co-authored-by: Nhu Dinh <150406148+nhudinh0309@users.noreply.github.com> * V16: Updates Language menu label locator (#300) * Language menu locate exact label text This is to support PR umbraco/Umbraco-CMS#20458 * Bump version number * add new version (#302) Co-authored-by: Lan Nguyen Thuy <lnt@umbraco.dk> * V16 Cherrypick changes from 17 (#311) * Updated helpers * Bumped version * Add helper: for custom collection view (#313) * add helper for custom collection view * Update lib/helpers/ContentUiHelper.ts Co-authored-by: Nhu Dinh <150406148+nhudinh0309@users.noreply.github.com> * Update lib/helpers/ContentUiHelper.ts Co-authored-by: Nhu Dinh <150406148+nhudinh0309@users.noreply.github.com> * update some names --------- Co-authored-by: Lan Nguyen Thuy <lnt@umbraco.dk> Co-authored-by: Nhu Dinh <150406148+nhudinh0309@users.noreply.github.com> * V16 reverted updates from 17 (#314) * Updated helpers * Bumped version --------- Co-authored-by: NguyenThuyLan <116753400+NguyenThuyLan@users.noreply.github.com> Co-authored-by: Lan Nguyen Thuy <lnt@umbraco.dk> Co-authored-by: Lee Kelleher <leekelleher@users.noreply.github.com> Co-authored-by: Andreas Zerbst <73799582+andr317c@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With updates made to localizations in umbraco/Umbraco-CMS#20458, the acceptance tests were failing.
I needed to update the locator for "Languages" menu to be "exact".
I have bumped the version number to v16.0.54, (I'm unsure if this clashes with #298, or they'll be merged nicely).