Add back icon name in class attribute to work again with font icons#9666
Merged
nul800sebastiaan merged 1 commit intoumbraco:v8/contribfrom Jan 19, 2021
Merged
Conversation
Contributor
Author
|
@nul800sebastiaan @nathanwoulfe maybe you can have a look at this? 👍 |
nul800sebastiaan
added
category/ui
Member
|
Thanks @bjarnef - I've cherry-picked for 8.10 and 8.11 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #9665
Description
I noticed in users section some icons were missing 🙈
I figured out that I removed the icon name from the class here, because I thought it wasn't necessary:
a9a4b08#diff-6a8c6488e5f6832a8854541a572ad9893f004e32733a52fe2591fec34a0344deL3
Now it works again!
Mostly you won't notice in core, because we have SVG icons for most of the old font icon classes. But currently it IS necessary currently, when the icon isn't available as SVG icon: #9255
At least until we find a better way to handle this and since many packages are using
<umb-node-preview>component and probably with font icons since that was the original approach.