Fix styling of search icon in search filter#9631
Merged
OwainWilliams merged 1 commit intoumbraco:v8/contribfrom Jan 13, 2021
Merged
Fix styling of search icon in search filter#9631OwainWilliams merged 1 commit intoumbraco:v8/contribfrom
OwainWilliams merged 1 commit intoumbraco:v8/contribfrom
Conversation
This was referenced Jan 10, 2021
OwainWilliams
requested review from
OwainWilliams
and removed request for
OwainWilliams
OwainWilliams
approved these changes
Jan 13, 2021
Contributor
OwainWilliams
left a comment
OwainWilliams
left a comment
There was a problem hiding this comment.
Looks good. Thanks @bjarnef - This does indeed fix the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #9541
Description
This PR fixes some styling issues with search icon inside search filter after the
<umb-search-filter>component has been introduced and changed to<umb-icon>inside search filter component, where theicon-searchwas removed. I have kept to old class so it still looks nice if packages used the old markup.It seems a bit unnecessary to have the
w-100class herehttps://github.com/umbraco/Umbraco-CMS/blob/v8/contrib/src/Umbraco.Web.UI.Client/src/less/components/umb-search-filter.less#L6-L8 since we already have the utility class here https://github.com/umbraco/Umbraco-CMS/blob/v8/contrib/src/Umbraco.Web.UI.Client/src/less/utilities/_width.less#L24
but removing this + the
htmlselector in the component styling, it seems the styling in forms.less is prioritized, so the padding was overwritten by forms.less styling.https://github.com/umbraco/Umbraco-CMS/blob/v8/contrib/src/Umbraco.Web.UI.Client/src/less/components/umb-search-filter.less#L14-L19
We can look at this in another PR. For now this should fix these styling issues.
Icon Picker
DataType Picker
