Replaced <i> with umb-icon directive in languages overview#9557
Merged
nathanwoulfe merged 2 commits intoumbraco:v8/contribfrom Jan 27, 2021
Merged
Conversation
poornimanayar
changed the title
bjarnef
reviewed
Dec 16, 2020
nathanwoulfe
approved these changes
Jan 27, 2021
Contributor
nathanwoulfe
left a comment
nathanwoulfe
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @poornimanayar
nathanwoulfe
added
category/ui
Contributor
|
@nathanwoulfe for now we still need icon name in class attribute. In this case is is probably only in core, but would potentially break if you overwrite the |
|
I guess one question is - are icons really semantic content or presentation - i.e. do they belong in the html at all ? |
Contributor
|
@bjarnef for all uses? I thought that was only the case where an SVG version didn't exist? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I have replaced
<i>with anumb-iconin the languages overview screenPoornima