Ability to define accept file extensions for FileUpload and use these to determine Media Type for File Uploads#9377
Closed
nielslyngsoe wants to merge 9 commits intov8/devfrom
Closed
Conversation
…pes' into v8/feature/AB9263-Refine-media-types
Contributor
|
I've been wanting this for so long 😍 |
Member
Author
|
@skttl great! Do you know about other low hanging fruits, that would be great to get solved? This one was quite simple and I think it will help out editors a lot in their work. Especially with the new media picker coming up where we can limit the ability to pick certain media types. If you like to peek: |
Contributor
|
I'll give it a spin later - looks promising! |
Member
Author
|
@skttl cool, still in progress :-) but let us know what you think |
Contributor
|
Hey Niels! I'm going to close this one as we have the functionality as part of mediapicker v3. I'm going to check for any functionality we don't already have that is in here and raise issues accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to define accepted file extensions for FileUpload and use these to determine Media Type for File Uploads.
Prepare:
Create new Media Type (named "Video") with new File Upload Data type for umbracoFile-property.
Set the accepted file extensions for this new data type to ex.: mov and mp4
Create another set that takes mp3 name it "Sound".
Test Notes:
General testing that uploaded files are made of the Media Type that fits the file extension.
Test creating new items through create menu, see the you can only pick files that matches the file extension.
Test that Media Type "File" still can pick any file.
Test dragging files of these new types get creates as the defined media type.
Check that image files that are not define by any media type are created as media.
Check that folders and other files still works as before.