Accessibility: Fixes for "insert code snippet" view in macro pickers#8711
Merged
nul800sebastiaan merged 3 commits intoumbraco:v8/contribfrom Aug 26, 2020
BatJan:feature/accessibility-fixes-for-insert-code-snippet
Merged
Accessibility: Fixes for "insert code snippet" view in macro pickers#8711nul800sebastiaan merged 3 commits intoumbraco:v8/contribfrom BatJan:feature/accessibility-fixes-for-insert-code-snippet
nul800sebastiaan merged 3 commits intoumbraco:v8/contribfrom
BatJan:feature/accessibility-fixes-for-insert-code-snippet
Conversation
BatJan
changed the title
1 task
Member
|
Sweet, looks good @BatJan - great job! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
During the work on #8522 I discovered that this view did not contain proper
<button>elements, for the different insert options, which means the focus lock won't be able to pickup the first focusable element properly and puts the focus on the "close" button making one unable to tab to the options inside the overlay. This is fixed in this PR with the added buttons. While I had the view opened I fixed some HTML semantics as well addingh2for the title and wrapped the description in<p>- I also added proper fallback texts in case the dictionary keys have not been translated for a certain language.The view visually appears the same as before these changes - I decided to make this an independent PR in an attempt to keep the #8522 as clean as possible 👍