Various fixes for macroparameterpicker view#8606
Merged
nul800sebastiaan merged 2 commits intoumbraco:v8/contribfrom Aug 31, 2020
BatJan:feature/various-fixes-for-macroparameterpicker-view
Merged
Various fixes for macroparameterpicker view#8606nul800sebastiaan merged 2 commits intoumbraco:v8/contribfrom BatJan:feature/various-fixes-for-macroparameterpicker-view
nul800sebastiaan merged 2 commits intoumbraco:v8/contribfrom
BatJan:feature/various-fixes-for-macroparameterpicker-view
Conversation
…been added for a language
…hide <i> for screen readers
1 task
Member
|
Thanks @BatJan, lovely work 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
During the work I'm currently doing on #8522 I noticed that there were some issues in this view where tabbing between the items would have a weird double effect. This PR addresses those issues + hides the
<i>element from screen readers and provides an English fallback text in case the dictionary key does not exist for a certain language.In the gif's below I display what the filter acts like as well since it's 2 different parts of the code.
Before
After
