UI: Corrected validation indication in variant-picker#8064
Merged
warrenbuckley merged 2 commits intov8/feature/AB6057-segment-featurefrom May 5, 2020
Conversation
…long as a error is present. Plus avoid displaying field-errors, we only want to use property errors for this indication.
nielslyngsoe
added
category/front-end
state/sprint-candidate
warrenbuckley
deleted the
v8/bugfix/7964-fix-validation-indication-in-variant-picker
branch
Contributor
|
All good :) |
umbrabot
removed
the
state/sprint-candidate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure that validation indication in variant-picker only stays as long as an error is present. Plus avoid displaying field-errors, we only want to use property errors for this indication.
This PR is an addition to the work for Segments, the reason for this PR to target this is that Segments will soon be merged and include a ton of changes to variant-picker. This way we minimize merge errors.
fixes #7964
This item has been added to our backlog AB#6512