Skip to content

Pagination: 100% wide - #23640

Merged
AndyButland merged 4 commits into
v17/devfrom
v17/bugifx/uui-pagination-styling
Aug 12, 2026
Merged

Pagination: 100% wide#23640
AndyButland merged 4 commits into
v17/devfrom
v17/bugifx/uui-pagination-styling

Conversation

@nielslyngsoe

@nielslyngsoe nielslyngsoe commented Aug 12, 2026

Copy link
Copy Markdown
Member

Fixes the change from UUI v.1 to v.2 where the pagination component handles its display property on its own.

Test Notes:
Review the various places a Pagination component is used, for example, in a collection in Documents.

Screenshots below show Pagination because page size has been set to 10.

Before:
image

After:
image

Copilot AI lite review requested due to automatic review settings August 12, 2026 09:20
@claude

claude Bot commented Aug 12, 2026

Copy link
Copy Markdown

Claude finished @nielslyngsoe's task in 3m 44s —— View job


PR Review

  • Gather context and read changed files
  • Analyze changes and check for issues
  • Post review findings
  • Apply labels (area/frontend, category/ui)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates backoffice Lit element styles to remove local uui-pagination display/flex overrides so the UUI v2 pagination component can control its own display behavior (notably its full-width rendering) consistently across the UI.

Changes:

  • Removed display/flex/inline-block overrides from uui-pagination in multiple views and modals.
  • Kept only spacing-related styling (e.g., margin-top / margin-bottom) around pagination.
  • Simplified pagination layout in places where centering is handled by surrounding containers rather than by forcing pagination display styles.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Umbraco.Web.UI.Client/src/packages/user/current-user/history/current-user-history-user-profile-app.element.ts Removes flex centering styles from uui-pagination, leaving only margin spacing.
src/Umbraco.Web.UI.Client/src/packages/relations/relations/reference/workspace-info-app/entity-references-workspace-view-info.element.ts Removes uui-pagination flex/display overrides; relies on wrapper layout.
src/Umbraco.Web.UI.Client/src/packages/relations/relation-types/workspace/relation-type/views/relation-type-detail-workspace-view.element.ts Removes forced display: block so UUI controls pagination display.
src/Umbraco.Web.UI.Client/src/packages/packages/package-section/views/created/packages-created-overview.element.ts Removes display: inline-block override on uui-pagination.
src/Umbraco.Web.UI.Client/src/packages/members/member-group/components/member-group-picker-modal/member-group-picker-modal.element.ts Removes forced display: block override from pagination styling.
src/Umbraco.Web.UI.Client/src/packages/media/media/modals/media-picker/media-picker-modal.element.ts Removes forced display: block override from pagination styling.
src/Umbraco.Web.UI.Client/src/packages/media/media/audit-log/info-app/media-history-workspace-info-app.element.ts Removes pagination flex centering overrides, keeping margin spacing.
src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/views/search/components/log-viewer-messages-list.element.ts Removes forced display: block override from pagination styling.
src/Umbraco.Web.UI.Client/src/packages/documents/documents/audit-log/info-app/document-history-workspace-info-app.element.ts Removes pagination flex centering overrides, keeping margin spacing.
src/Umbraco.Web.UI.Client/src/packages/documents/document-redirect-management/dashboard-redirect-management.element.ts Removes display: inline-block override so pagination can size itself.
src/Umbraco.Web.UI.Client/src/packages/core/tree/components/tree-pagination.element.ts Removes forced display: block override from core tree pagination styling.
src/Umbraco.Web.UI.Client/src/packages/core/picker/search/picker-search-result.element.ts Removes forced display: block override from picker search pagination styling.
src/Umbraco.Web.UI.Client/src/packages/core/collection/components/pagination/collection-pagination.element.ts Removes forced display: block override from collection pagination styling.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@claude

claude Bot commented Aug 12, 2026

Copy link
Copy Markdown

PR Review

Target: origin/v17/dev · Based on commit: b5ca5833 · Skipped: 0 files out of 13 total

Removes redundant display overrides from all uui-pagination selectors across 13 files to fix a regression introduced by the UUI v1→v2 migration, where the component now manages its own display property internally.


Important

  • src/Umbraco.Web.UI.Client/src/packages/content/content/audit-log/info-app/content-audit-log-workspace-info-app.element.ts:229: This file still has flex: 1; display: flex; justify-content: center; on uui-pagination — the same pattern removed from document-history-workspace-info-app.element.ts and media-history-workspace-info-app.element.ts. Per the deprecation note in the document history file, this element (UmbContentAuditLogWorkspaceInfoAppElement) is the active non-deprecated replacement, so it will render inconsistently with UUI v2 unless updated too.

Approved with Suggestions for improvement

Good to go, but the missed file above is worth addressing to keep the fix complete and consistent.

@claude claude Bot added area/frontend category/ui User interface labels Aug 12, 2026
@AndyButland
AndyButland enabled auto-merge (squash) August 12, 2026 10:09
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants