Pagination: 100% wide - #23640
Conversation
|
Claude finished @nielslyngsoe's task in 3m 44s —— View job PR Review
|
There was a problem hiding this comment.
Pull request overview
This PR updates backoffice Lit element styles to remove local uui-pagination display/flex overrides so the UUI v2 pagination component can control its own display behavior (notably its full-width rendering) consistently across the UI.
Changes:
- Removed
display/flex/inline-block overrides fromuui-paginationin multiple views and modals. - Kept only spacing-related styling (e.g.,
margin-top/margin-bottom) around pagination. - Simplified pagination layout in places where centering is handled by surrounding containers rather than by forcing pagination display styles.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/user/current-user/history/current-user-history-user-profile-app.element.ts | Removes flex centering styles from uui-pagination, leaving only margin spacing. |
| src/Umbraco.Web.UI.Client/src/packages/relations/relations/reference/workspace-info-app/entity-references-workspace-view-info.element.ts | Removes uui-pagination flex/display overrides; relies on wrapper layout. |
| src/Umbraco.Web.UI.Client/src/packages/relations/relation-types/workspace/relation-type/views/relation-type-detail-workspace-view.element.ts | Removes forced display: block so UUI controls pagination display. |
| src/Umbraco.Web.UI.Client/src/packages/packages/package-section/views/created/packages-created-overview.element.ts | Removes display: inline-block override on uui-pagination. |
| src/Umbraco.Web.UI.Client/src/packages/members/member-group/components/member-group-picker-modal/member-group-picker-modal.element.ts | Removes forced display: block override from pagination styling. |
| src/Umbraco.Web.UI.Client/src/packages/media/media/modals/media-picker/media-picker-modal.element.ts | Removes forced display: block override from pagination styling. |
| src/Umbraco.Web.UI.Client/src/packages/media/media/audit-log/info-app/media-history-workspace-info-app.element.ts | Removes pagination flex centering overrides, keeping margin spacing. |
| src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/views/search/components/log-viewer-messages-list.element.ts | Removes forced display: block override from pagination styling. |
| src/Umbraco.Web.UI.Client/src/packages/documents/documents/audit-log/info-app/document-history-workspace-info-app.element.ts | Removes pagination flex centering overrides, keeping margin spacing. |
| src/Umbraco.Web.UI.Client/src/packages/documents/document-redirect-management/dashboard-redirect-management.element.ts | Removes display: inline-block override so pagination can size itself. |
| src/Umbraco.Web.UI.Client/src/packages/core/tree/components/tree-pagination.element.ts | Removes forced display: block override from core tree pagination styling. |
| src/Umbraco.Web.UI.Client/src/packages/core/picker/search/picker-search-result.element.ts | Removes forced display: block override from picker search pagination styling. |
| src/Umbraco.Web.UI.Client/src/packages/core/collection/components/pagination/collection-pagination.element.ts | Removes forced display: block override from collection pagination styling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
PR ReviewTarget: Removes redundant Important
Approved with Suggestions for improvementGood to go, but the missed file above is worth addressing to keep the fix complete and consistent. |
|
do not declare display block on uui-pagination



Fixes the change from UUI v.1 to v.2 where the pagination component handles its display property on its own.
Test Notes:
Review the various places a Pagination component is used, for example, in a collection in Documents.
Screenshots below show Pagination because page size has been set to 10.
Before:

After:
