-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Hotfix: Reintroduce deprecated UUI components #23628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
madsrasmussen
merged 5 commits into
release/17.6.1
from
v17/hotfix/bring-popover-and-caret-for-uui
Aug 11, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ad72e8a
implement and export deprecated components popover and caret
nielslyngsoe 723428a
fix imports
nielslyngsoe d4083d0
fix uui-caret
nielslyngsoe 57af6c5
Potential fix for pull request finding
nielslyngsoe 0879ca2
Potential fix for pull request finding
nielslyngsoe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6 changes: 6 additions & 0 deletions
6
src/Umbraco.Web.UI.Client/src/external/uui/UUIPopoverEvent.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import { UUIEvent } from '@umbraco-ui/uui'; | ||
| import type { UUIPopoverElement } from './uui-popover.element.js'; | ||
|
|
||
| export class UUIPopoverEvent extends UUIEvent<{}, UUIPopoverElement> { | ||
| public static readonly CLOSE = 'close'; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
src/Umbraco.Web.UI.Client/src/external/uui/uui-caret.element.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| import { defineElement } from '@umbraco-ui/uui'; | ||
| import { css, html, LitElement, property } from '../lit'; | ||
|
|
||
| /** | ||
| * DEPRECATED: Please use uui-symbol-expand or uui-symbol-sort. A caret that rotates on click. Color will be `currentColor` | ||
| * @deprecated since version 0.0.8 | ||
| * @element uui-caret | ||
| */ | ||
| @defineElement('uui-caret') | ||
| export class UUICaretElement extends LitElement { | ||
| /** | ||
| * Turns the arrow around. | ||
| * @type {boolean} | ||
| * @default false | ||
| */ | ||
| @property({ type: Boolean, reflect: true }) | ||
| public open = false; | ||
|
|
||
| constructor() { | ||
| super(); | ||
| console.error('´uui-caret´ is deprecated, please use ´uui-symbol-expand´ or ´uui-symbol-sort´'); | ||
| } | ||
|
|
||
| override render() { | ||
| return html`<svg | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| viewBox="0 0 24 24" | ||
| fill="none" | ||
| stroke="currentColor" | ||
| stroke-width="3" | ||
| stroke-linecap="round" | ||
| stroke-linejoin="round"> | ||
| <path d="m4 9 8 8 8-8"></path> | ||
| </svg>`; | ||
| } | ||
|
|
||
| static override styles = [ | ||
| css` | ||
| :host { | ||
| display: inline-block; | ||
| width: 12px; | ||
| vertical-align: middle; | ||
| } | ||
|
|
||
| svg { | ||
| transform-origin: 50% 50%; | ||
| transition: transform 100ms cubic-bezier(0.1, 0, 0.9, 1); | ||
| } | ||
|
|
||
| :host([open]) svg { | ||
| transform: rotate(180deg); | ||
| } | ||
| `, | ||
| ]; | ||
| } | ||
|
|
||
| declare global { | ||
| interface HTMLElementTagNameMap { | ||
| 'uui-caret': UUICaretElement; | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.