Hotfix: adding backwards compatible exports - #23626
Merged
nielslyngsoe merged 6 commits intoAug 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds backward-compatible export names in the backoffice “external/uui” bridge to ease migration/compatibility with legacy UUI 1.x code while using UUI 2.x.
Changes:
- Adds deprecated aliases (
Timer,ActiveMixinInterface, etc.) mapping legacy names to UUI 2.x exports. - Reintroduces a deprecated
demandCustomElementhelper to warn when required custom elements are not registered.
Suppressed comments (2)
src/Umbraco.Web.UI.Client/src/external/uui/index.ts:32
- The new JSDoc has a few typos/grammar issues (e.g., “v.17”, “not begin available”, double period) and uses a non-standard
@functag. Since this is a compatibility shim with a planned removal, it would be good to make the deprecation/TODO line consistent with the existingTODO (Vxx)style in this file and tighten the wording.
* For v.17 we need to keep this function around for backwards compatibility with the legacy UUI 1.x custom elements.
* TODO: To be removed in v.18.
* Fire a warning if the custom element with the provided name isn't available.
* @func demandCustomElement
* @param {HTMLElement} requester - Reference to the element requiring this custom element..
src/Umbraco.Web.UI.Client/src/external/uui/index.ts:39
- The default warning
messagestring has a grammar issue (“work appropriate”). Since this is user-facing in the dev console, consider making it read naturally.
message: string = `This element has to be present for ${requester.nodeName} to work appropriate.`,
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ity-adjustments # Conflicts: # src/Umbraco.Web.UI.Client/src/external/uui/index.ts
nielslyngsoe
enabled auto-merge (squash)
August 11, 2026 09:32
madsrasmussen
added
release/17.6.1
area/frontend
status/regression
madsrasmussen
approved these changes
Aug 11, 2026
|
nielslyngsoe
deleted the
v17/hotfix/uui-backward-compatability-adjustments
branch
August 11, 2026 10:13
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a few named exports for backwards compatibility with UUI v.1