Avoid some string allocations - #23402
Conversation
|
Hi there @Henr1k80, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
AndyButland
left a comment
There was a problem hiding this comment.
Thanks again @Henr1k80. Looks good, though I believe a regression has sneaked in here, so could you look at that before we merge please?
…r overload when trimming elsewhere
…ving redundant re-check and the Ordinal/InvariantCulture inconsistency.
AndyButland
left a comment
There was a problem hiding this comment.
Thanks for the updates @Henr1k80 - looks good to me now.
Prerequisites
Description
Avoid allocating strings when spans can be used when:
This is archived by using spans from regex matches, trimming on spans & spans instead of sub-strings.
There is also
@AndyButland v17 version of #23399