Member Types: Fixed issue with missing icon for workspace design view - #23391
Conversation
The `icon-member-dashed-line` doesn't exist. The corresponding workspace views for document and media both use `icon-document-dashed-line`, so we might as well do that here instead of introducing `icon-member-dashed-line`.
|
Hi there @abjerner, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
AndyButland
left a comment
There was a problem hiding this comment.
Thanks @abjerner - works as expected to fix the bug, and the icon aligns with what we have for document and media types, so seems the correct choice.
An icon with the alias
icon-member-dashed-linedoesn't exist. The corresponding workspace views for document and media both useicon-document-dashed-line, so we might as well do the same here instead of introducingicon-member-dashed-line.Prerequisites
Description
By default, we don't see the tab for Design workspace view as it's not shown if there aren't any other workspace view. But if you do add another workspace view, you can see that the icon for Design isn't shown.
The issue is that the Design workspace view extension specifies that the icon should be
icon-member-dashed-line, but this doesn't exist. Usingicon-document-dashed-linefixes the issue.