Skip to content

Member Types: Fixed issue with missing icon for workspace design view - #23391

Merged
AndyButland merged 1 commit into
umbraco:v17/devfrom
abjerner:patch-3
Jul 16, 2026
Merged

AndyButland merged 1 commit into
umbraco:v17/devfrom
abjerner:patch-3

Conversation

@abjerner

Copy link
Copy Markdown
Contributor

An icon with the alias icon-member-dashed-line doesn't exist. The corresponding workspace views for document and media both use icon-document-dashed-line, so we might as well do the same here instead of introducing icon-member-dashed-line.

Prerequisites

  • I have added steps to test this contribution in the description below

Description

By default, we don't see the tab for Design workspace view as it's not shown if there aren't any other workspace view. But if you do add another workspace view, you can see that the icon for Design isn't shown.

image

The issue is that the Design workspace view extension specifies that the icon should be icon-member-dashed-line, but this doesn't exist. Using icon-document-dashed-line fixes the issue.

The `icon-member-dashed-line` doesn't exist. The corresponding workspace views for document and media both use `icon-document-dashed-line`, so we might as well do that here instead of introducing `icon-member-dashed-line`.
@github-actions

Copy link
Copy Markdown

Hi there @abjerner, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@AndyButland AndyButland changed the title Fixed issue with missing icon for Member Type Workspace Design View Member Types: Fixed issue with missing icon for workspace design view Jul 16, 2026
@AndyButland
AndyButland changed the base branch from contrib to v17/dev July 16, 2026 05:16

@AndyButland AndyButland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abjerner - works as expected to fix the bug, and the icon aligns with what we have for document and media types, so seems the correct choice.

@AndyButland
AndyButland enabled auto-merge (squash) July 16, 2026 05:23
@AndyButland
AndyButland disabled auto-merge July 16, 2026 05:24
@AndyButland
AndyButland merged commit 64649d0 into umbraco:v17/dev Jul 16, 2026
9 of 12 checks passed
This was referenced Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants